Re: [PATCH 02/14] docs: add bus-virt-phys-mapping.txt to core-api

Mauro Carvalho Chehab
2020-05-22T04:22:31Z

Em Fri, 15 May 2020 11:53:21 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:

> On Fri, 1 May 2020 17:37:46 +0200
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
>
> > This describes an old interface used prior the new DMA-API
> > interfaces. Add it to the core-api guide, just after the
> > DMA stuff.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> > .../bus-virt-phys-mapping.rst} | 0
> > Documentation/core-api/index.rst | 1 +
> > 2 files changed, 1 insertion(+)
> > rename Documentation/{bus-virt-phys-mapping.txt => core-api/bus-virt-phys-mapping.rst} (100%)
>
> For this one, I think we should maybe just delete the file. It contains a
> warning from *20 years ago* saying not to use it, and talks about
> functions like isa_readl() that haven't existed i the kernel for some
> time. Is there any reason to keep dragging it around?

Except for "keeping it for historical reasons" (as mentioned at the
file), I don't see any reason why to keep it.

It might be useful if someone wants to port some OOT code based on
a legacy kernel.

Yet, if you prefer to just trash it, I'm ok with that.

Thanks,
Mauro