From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A31C433E1 for ; Fri, 15 May 2020 12:37:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F2D32074D for ; Fri, 15 May 2020 12:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbgEOMhM (ORCPT ); Fri, 15 May 2020 08:37:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:25710 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgEOMhM (ORCPT ); Fri, 15 May 2020 08:37:12 -0400 IronPort-SDR: pneLbE16RwHOol9ExixIWXIskz2yGmmOtNF7SO4rky20ZJwPjOCtwS9RdU9AIoRzeNeDzYB0HD DqdPb1+npt0g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 05:37:11 -0700 IronPort-SDR: MSSMqBWQSRkTPqioy+AVBCKIQQ6v+z9cIciN7NuFyP0CxYTzi4PEVeZ2q3nvdeNLNAVKfuZCdW vJT+SBAfJrnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="252021119" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 15 May 2020 05:37:05 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZZaI-006rD7-7x; Fri, 15 May 2020 15:37:02 +0300 Date: Fri, 15 May 2020 15:37:02 +0300 From: Andy Shevchenko To: Mark Brown Cc: Serge Semin , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, Jarkko Nikula , Wan Ahmad Zainie , Thomas Gleixner , "wuxu.wu" , Clement Leger , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/19] spi: dw: Add Tx/Rx finish wait methods to the MID DMA Message-ID: <20200515123702.GA185537@smile.fi.intel.com> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-3-Sergey.Semin@baikalelectronics.ru> <20200515120111.GV185537@smile.fi.intel.com> <20200515121815.GB5066@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515121815.GB5066@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 01:18:15PM +0100, Mark Brown wrote: > On Fri, May 15, 2020 at 03:01:11PM +0300, Andy Shevchenko wrote: > > > General question, doesn't spi core provides us some helpers like > > spi_delay_exec()? > > Well, nobody wrote one. spi_delay_exec() seems quite good to be used here. Can we use it for delays? > It's also a bit tricky to handle given that > often you're checking some controller specific things while a FIFO in > the IP drains/fills, though nothing insurmountable. Yes, input can be gathered by reading controller specific data. -- With Best Regards, Andy Shevchenko