From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2263BC433DF for ; Fri, 15 May 2020 14:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3D35206B6 for ; Fri, 15 May 2020 14:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589551308; bh=yb8R+GOwH48wvwdqIqTwFW7+aoOd4AT8rCjotJZTQ5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mIYFaiC6RDn0i3wvPn8AeMgDXS4kIshH0U1DQdZV5AnPFn2BhMGvLq7CJ3y1iqV4O mUvQofurv1T9uSkxIGL3UuJOgmKL7Nx+h4V8vaQM2khfi6jYTOMpjPTCR2dAjH6eOL 0Ko/Aq9aL7k2RYGoYprdR1yvfaRV7gCvRPYixKXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726727AbgEOOBr (ORCPT ); Fri, 15 May 2020 10:01:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbgEOOBq (ORCPT ); Fri, 15 May 2020 10:01:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BAA720671; Fri, 15 May 2020 14:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589551306; bh=yb8R+GOwH48wvwdqIqTwFW7+aoOd4AT8rCjotJZTQ5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wnJ15YHkDuxgPEDcXu0Asv5Ce+o7iO7Wr9Vqz3062cKJXLxMjiTp6zCv53ly7VTwn zTRdyxO4zrNhGnifGAZdjAqGGZcU57JnmTJUQSRpklPeVbcKozjUUmR8jOQUwCw9vU sD9NW5ewrlCGr5FkboTSR5IsFKMhMqwkayD1myzg= Date: Fri, 15 May 2020 16:01:28 +0200 From: Greg Kroah-Hartman To: Jerome Pouiller Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Kalle Valo Subject: Re: [PATCH 05/19] staging: wfx: fix coherency of hif_scan() prototype Message-ID: <20200515140128.GA2182376@kroah.com> References: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> <20200515083325.378539-6-Jerome.Pouiller@silabs.com> <20200515135359.GA2162457@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200515135359.GA2162457@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 03:53:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > The function hif_scan() return the timeout for the completion of the > > scan request. It is the only function from hif_tx.c that return another > > thing than just an error code. This behavior is not coherent with the > > rest of file. Worse, if value returned is positive, the caller can't > > make say if it is a timeout or the value returned by the hardware. > > > > Uniformize API with other HIF functions, only return the error code and > > pass timeout with parameters. > > > > Signed-off-by: Jérôme Pouiller > > --- > > drivers/staging/wfx/hif_tx.c | 6 ++++-- > > drivers/staging/wfx/hif_tx.h | 2 +- > > drivers/staging/wfx/scan.c | 6 +++--- > > 3 files changed, 8 insertions(+), 6 deletions(-) > > This patch fails to apply to my branch, so I've stopped here in the > patch series. > > Can you rebase and resend the remaining ones? Ok, all others worked, just this one failed, so I've applied them. greg k-h