From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1F1C433E0 for ; Fri, 15 May 2020 14:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44F062078C for ; Fri, 15 May 2020 14:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589553911; bh=11QCz4wj0IRYOsP8TSzEDA1ar1cIM8puU3El5/WrkVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nSufKDrO9d7RGLtPcjtynqwdwBMMTguoXxGown1QB5VFigJw4rdzjNVcHIc17aZSY FfuFKV6UzqNMK4l5UwZE0haYcWK/QGzm30VX8lGcL0B4JXBX+eUf4mz2ROpPWWz2Qj nuQ0mL5UEmP7IoJO87zuTg8VHuunAf/0wKiLPcWw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbgEOOpK (ORCPT ); Fri, 15 May 2020 10:45:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:60470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbgEOOpK (ORCPT ); Fri, 15 May 2020 10:45:10 -0400 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5F4320671; Fri, 15 May 2020 14:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589553909; bh=11QCz4wj0IRYOsP8TSzEDA1ar1cIM8puU3El5/WrkVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OlAW9ahgqgxfR8cXxImDaOO46Cnzdv4vh2+mbxjE0y3uKG1qx3xRCPMMS8HG7NDh5 tkFYpwUohUuIUa1bP+R9mvELw7n4OMAfJM/hA4bgvqyII4yEi5SE3BeQv/JBw20yf0 KOpRb93VlfcGn9OzGvNVWjSgbBApluGmHdFqCPWM= Date: Fri, 15 May 2020 07:45:09 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Subject: Re: [f2fs-dev] [PATCH] f2fs: flush dirty meta pages when flushing them Message-ID: <20200515144509.GA46028@google.com> References: <20200515021554.226835-1-jaegeuk@kernel.org> <9ba6e5ef-068d-a925-1eb9-107b0523666c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ba6e5ef-068d-a925-1eb9-107b0523666c@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15, Chao Yu wrote: > On 2020/5/15 10:15, Jaegeuk Kim wrote: > > Let's guarantee flusing dirty meta pages to avoid infinite loop. > > What's the root cause? Race case or meta page flush failure? Investigating, but at least, this can avoid the inifinite loop there. V2: >From c60ce8e7178004fd6cba96e592247e43b5fd98d8 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Wed, 13 May 2020 21:12:53 -0700 Subject: [PATCH] f2fs: flush dirty meta pages when flushing them Let's guarantee flusing dirty meta pages to avoid infinite loop. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 620a386d82c1a..3dc3ac6fe1432 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -1266,6 +1266,9 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, int type) if (unlikely(f2fs_cp_error(sbi))) break; + if (type == F2FS_DIRTY_META) + f2fs_sync_meta_pages(sbi, META, LONG_MAX, + FS_CP_META_IO); io_schedule_timeout(DEFAULT_IO_TIMEOUT); } finish_wait(&sbi->cp_wait, &wait); -- 2.26.2.761.g0e0b3e54be-goog