Re: [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object

Ardelean, Alexandru
2020-05-22T06:58:35Z

On Thu, 2020-05-14 at 16:17 +0300, Alexandru Ardelean wrote:
> This change starts to hide some internal fields of the IIO device into
> the framework.
>
> Because the iio_priv_to_dev() will be hidden some pre-work is done to
> try to remove it from some interrupt handlers.
> iio_priv_to_dev() will become a function call and won't be expandable
> into place (as-is now as an inline function).
>

I'll defer this series.
A cleanup of iio_priv_to_dev() doesn't look like a bit detour.

> Changelog v1 -> v2:
> - add pre-work patches that remove some calls to iio_priv_to_dev() from
> interrupt handlers
> - renamed iio_dev_priv -> iio_dev_opaque
> - moved the iio_dev_opaque to 'include/linux/iio/iio-opaque.h' this way
> it should be usable for debugging
> - the iio_priv() call, is still an inline function that returns an
> 'indio_dev->priv' reference; this field is added to 'struct iio_dev';
> the reference is computed in iio_device_alloc() and should be
> cacheline aligned
> - the to_iio_dev_opaque() container is in the
> 'include/linux/iio/iio-opaque.h' header; it's still implemented with
> some pointer arithmetic; one idea was to do it via an
> 'indio_dev->opaque' field; that may still be an optionif there are
> some opinions in that direction
>
> Alexandru Ardelean (8):
> iio: proximity: ping: pass reference to IIO device via call-stack
> iio: at91-sama5d2_adc: pass ref to IIO device via param for int
> function
> iio: at91_adc: pass ref to IIO device via param for int function
> iio: stm32-dfsdm-adc: pass iio device as arg for the interrupt handler
> iio: stm32-adc: pass iio device as arg for the interrupt handler
> iio: core: wrap IIO device into an iio_dev_opaque object
> iio: core: simplify alloc alignment code
> iio: core: move debugfs data on the private iio dev info
>
> drivers/iio/adc/at91-sama5d2_adc.c | 7 ++-
> drivers/iio/adc/at91_adc.c | 5 +-
> drivers/iio/adc/stm32-adc.c | 10 ++--
> drivers/iio/adc/stm32-dfsdm-adc.c | 6 +--
> drivers/iio/industrialio-core.c | 75 ++++++++++++++++++++----------
> drivers/iio/proximity/ping.c | 5 +-
> include/linux/iio/iio-opaque.h | 27 +++++++++++
> include/linux/iio/iio.h | 24 +++-------
> 8 files changed, 99 insertions(+), 60 deletions(-)
> create mode 100644 include/linux/iio/iio-opaque.h
>