Re: [PATCH] ARM: kprobes: Avoid fortify_panic() when copying optprobe template

Andrew Jeffery
2020-05-19T00:23:12Z

On Mon, 18 May 2020, at 11:50, Masami Hiramatsu wrote:
> On Sun, 17 May 2020 14:48:52 -0700
> Kees Cook <keescook@chromium.org> wrote:
>
> > On Mon, May 18, 2020 at 01:09:59AM +0930, Andrew Jeffery wrote:
> > > As mentioned, a couple of attempts have been made to address the issue
> > > by casting a pointer to optprobe_template_entry before providing it to
> > > memcpy(), however gccs such as Ubuntu 20.04's arm-linux-gnueabi-gcc
> > > 9.3.0 (Ubuntu 9.3.0-10ubuntu1) see through these efforts.
> >
> > Ah, dang. :P
> >
> > How about converting them all to unsized arrays, which would also allow
> > the code to drop the "&" everywhere, I think. This is untested:
> >
>
> This looks good to me since it uses same technique in sections.h.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>

Kees,

Were you planning to send resend this, or were you looking for me to polish it
up?

Andrew