From: Frederic Weisbecker <frederic@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
stable@kernel.org
Subject: Re: [PATCH] tick/nohz: Narrow down noise while setting current task's tick dependency
Date: Sun, 17 May 2020 18:20:02 +0200 [thread overview]
Message-ID: <20200517162001.GA30646@lenoir> (raw)
In-Reply-To: <20200517155322.GQ2869@paulmck-ThinkPad-P72>
On Sun, May 17, 2020 at 08:53:22AM -0700, Paul E. McKenney wrote:
> On Sun, May 17, 2020 at 03:31:16PM +0200, Frederic Weisbecker wrote:
> > On Fri, May 15, 2020 at 08:07:18PM -0700, Paul E. McKenney wrote:
> > > On Fri, May 15, 2020 at 02:34:29AM +0200, Frederic Weisbecker wrote:
> > > > So far setting a tick dependency on any task, including current, used to
> > > > trigger an IPI to all CPUs. That's of course suboptimal but it wasn't
> > > > an issue as long as it was only used by posix-cpu-timers on nohz_full,
> > > > a combo that nobody seemed to use in real life.
> > > >
> > > > But RCU started to use task tick dependency on current task to fix
> > > > stall issues on callbacks processing. These trigger regular and
> > > > undesired system wide IPIs on nohz_full.
> > > >
> > > > The fix is very easy while setting a tick dependency on the current
> > > > task, only its CPU needs an IPI.
> > >
> > > This passes moderate rcutorture testing. If you want me to take it, please
> > > let me know, and otherwise:
> > >
> > > Tested-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > If you already have a pending urgent queue, I'd love you to take it.
> > If not I can take it.
>
> Nothing urgent yet in -rcu, so if you would like it in the next merge
> window, please take it through your normal upstream path.
Got it, thanks!
next prev parent reply other threads:[~2020-05-17 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 0:34 [PATCH] tick/nohz: Narrow down noise while setting current task's tick dependency Frederic Weisbecker
2020-05-16 3:07 ` Paul E. McKenney
2020-05-17 13:31 ` Frederic Weisbecker
2020-05-17 15:53 ` Paul E. McKenney
2020-05-17 16:20 ` Frederic Weisbecker [this message]
2020-05-18 8:57 ` Peter Zijlstra
2020-05-18 13:25 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200517162001.GA30646@lenoir \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).