* [RFC PATCH linus] RISC-V: gp_in_global can be static [not found] <202005181328.2fITyRLh%lkp@intel.com> @ 2020-05-18 5:02 ` kbuild test robot 2020-05-21 20:51 ` Palmer Dabbelt 0 siblings, 1 reply; 2+ messages in thread From: kbuild test robot @ 2020-05-18 5:02 UTC (permalink / raw) To: Palmer Dabbelt; +Cc: kbuild-all, linux-kernel Fixes: 52e7c52d2ded ("RISC-V: Stop relying on GCC's register allocator's hueristics") Signed-off-by: kbuild test robot <lkp@intel.com> --- process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c index 610c11e916068..3b2933839d492 100644 --- a/arch/riscv/kernel/process.c +++ b/arch/riscv/kernel/process.c @@ -22,7 +22,7 @@ #include <asm/switch_to.h> #include <asm/thread_info.h> -unsigned long gp_in_global __asm__("gp"); +static unsigned long gp_in_global __asm__("gp"); extern asmlinkage void ret_from_fork(void); extern asmlinkage void ret_from_kernel_thread(void); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH linus] RISC-V: gp_in_global can be static 2020-05-18 5:02 ` [RFC PATCH linus] RISC-V: gp_in_global can be static kbuild test robot @ 2020-05-21 20:51 ` Palmer Dabbelt 0 siblings, 0 replies; 2+ messages in thread From: Palmer Dabbelt @ 2020-05-21 20:51 UTC (permalink / raw) To: lkp; +Cc: kbuild-all, linux-kernel On Sun, 17 May 2020 22:02:27 PDT (-0700), lkp@intel.com wrote: > > Fixes: 52e7c52d2ded ("RISC-V: Stop relying on GCC's register allocator's hueristics") > Signed-off-by: kbuild test robot <lkp@intel.com> > --- > process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c > index 610c11e916068..3b2933839d492 100644 > --- a/arch/riscv/kernel/process.c > +++ b/arch/riscv/kernel/process.c > @@ -22,7 +22,7 @@ > #include <asm/switch_to.h> > #include <asm/thread_info.h> > > -unsigned long gp_in_global __asm__("gp"); > +static unsigned long gp_in_global __asm__("gp"); > > extern asmlinkage void ret_from_fork(void); > extern asmlinkage void ret_from_kernel_thread(void); Thanks. Looks like this is actually a real bug: gp_in_global was supposed to have the "register" keyword, and missing that appears to cause the __asm__ to be ignored. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-21 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202005181328.2fITyRLh%lkp@intel.com>
2020-05-18 5:02 ` [RFC PATCH linus] RISC-V: gp_in_global can be static kbuild test robot
2020-05-21 20:51 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox