From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D19AC433E0 for ; Mon, 18 May 2020 21:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD448207C4 for ; Mon, 18 May 2020 21:14:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QyJ2yabW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgERVOP (ORCPT ); Mon, 18 May 2020 17:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgERVOO (ORCPT ); Mon, 18 May 2020 17:14:14 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB92C061A0C for ; Mon, 18 May 2020 14:14:14 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id ci21so405267pjb.3 for ; Mon, 18 May 2020 14:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iOTqBFjbUc15JVKUZQ3fGM2L6h0BsYo4USOrm5zOjvU=; b=QyJ2yabWgeLSe3uhlxGEGCdqXI7GGUQMHdHhZaMMgw/WkN7Ij2ODRj0KXr2ScfSqjB jy/FL1DUlvhZhUope/ZuuMXh4KneVfXf2MmI3mlhTREqRQ+7xz8aAy4xZmKt0svsG2Sa +2I9yrT7Ek3YJ30F1VDFRrtaLFmPpqUusgWm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iOTqBFjbUc15JVKUZQ3fGM2L6h0BsYo4USOrm5zOjvU=; b=QToCOJTBR9cPW06OC1QqUna5EwXc6a1u09/P1faldOEm3FKU3Nbkhk/5Zwar/p4/PX QmcR+uAqd4aWivfL07STHL0DuRU3DwJ+aAIJGI/CZq4n4p/PACGRam6wRIO+DaJO2+J4 5DT0UXu8a5OaoCxDQO0ghG+O/Ovb8Op8uOhbxOxSPwJMQd7szYHwmQNiWXip3bzIB0SP YTtGJKR0hjai6uUdMmqDCdWbETCDOWeC1drFFz67v8d+LYVzAit00ppFaEHOfzchmjAE EA+h9RuRQuJ8booffq22Ihz0HzJZcR4AyKdphXDKpZpU8dkMv1ZHcWhJVSliPu4Ei556 bIzw== X-Gm-Message-State: AOAM533PI/DLI3yi1HmOejmFYnX5Ej/U7Bpiwh46ybD+Xhp2sLD3oOlb bgeIvt2o+st+0NfEiPRct+Le4mqgfjk= X-Google-Smtp-Source: ABdhPJyhODLbzmuFhF6JGyvviQduFf54TxfdMAQHhQKoZO4RfjPkqc/t/GeGJicV4WkxDddupDqT0w== X-Received: by 2002:a17:90a:8c83:: with SMTP id b3mr1395133pjo.141.1589836453742; Mon, 18 May 2020 14:14:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k4sm8280834pgg.88.2020.05.18.14.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 14:14:12 -0700 (PDT) Date: Mon, 18 May 2020 14:14:11 -0700 From: Kees Cook To: Luis Chamberlain Cc: Xiaoming Ni , Andrew Morton , Stephen Kitt , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sysctl: const-ify ngroups_max Message-ID: <202005181413.A9A985574@keescook> References: <20200518155727.10514-1-steve@sk2.org> <202005180908.C016C44D2@keescook> <20200518172509.GM11244@42.do-not-panic.com> <202005181117.BB74974@keescook> <20200518183055.GN11244@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518183055.GN11244@42.do-not-panic.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 06:30:55PM +0000, Luis Chamberlain wrote: > On Mon, May 18, 2020 at 11:17:47AM -0700, Kees Cook wrote: > > On Mon, May 18, 2020 at 05:25:09PM +0000, Luis Chamberlain wrote: > > > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > > > > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > > > > > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > > > > > it const, in the same way as cap_last_cap. > > > > > > > > > > Signed-off-by: Stephen Kitt > > > > > > > > Reviewed-by: Kees Cook > > > > > > Kees, since there is quite a bit of sysctl cleanup stuff going on and I > > > have a fs sysctl kitchen cleanup, are you alright if I carry this in a > > > tree and send this to Andrew once done? This would hopefully avoid > > > merge conflicts between these patches. > > > > > > I have to still re-spin my fs sysctl stuff, but will wait to do that > > > once Xiaoming bases his series on linux-next. > > > > Yeah, totally. I don't technically have a sysctl tree (I've always just > > had akpm take stuff), so go for it. I'm just doing reviews. :) > > Oh, I don't want a tree either, it was just that I can imagine these > series can easily create conflcits, so I wanted to avoid that before > passing them on to Andrew. Yup, that's cool. I happily defer to you on these cleanups! :) -- Kees Cook