Re: [PATCH V4 8/8] arm64: dts: ipq6018: Add a53 pll and apcs clock

Sivaprakash Murugesan
2020-05-13T03:56:00Z

Hi Bjorn,

On 5/13/2020 1:54 AM, Bjorn Andersson wrote:
> On Sun 03 May 23:20 PDT 2020, Sivaprakash Murugesan wrote:
>
>> add support for apps pll and apcs clock.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 16 +++++++++++++---
>> 1 file changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index 1aa8d85..af2ceeb 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -294,12 +294,22 @@
>> };
>>
>> apcs_glb: mailbox@b111000 {
>> - compatible = "qcom,ipq8074-apcs-apps-global";
>> - reg = <0x0b111000 0xc>;
>> -
>> + compatible = "qcom,ipq6018-apcs-apps-global";
>> + reg = <0x0b111000 0x1000>;
> My documentation states that IPQ8074 indeed has this block at
> 0x0b111000, but IPQ6018 it's at 0x6b111000. Can you confirm this is
> correct? Same with the pll below.
The address 0x6b111000 is how the RPM sees this block. For A53 it is
still 0xb111000
>
> Apart from that the patch looks good.
>
> Regards,
> Bjorn