* [PATCH] MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c
@ 2020-05-19 12:28 Tiezhu Yang
2020-05-19 16:03 ` Thomas Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: Tiezhu Yang @ 2020-05-19 12:28 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel, Xuefeng Li
After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27
declarations to ip27-common.h"), ip27-common.h is included more
than once in ip27-timer.c, remove it.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
arch/mips/sgi-ip27/ip27-timer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
index 61f3565..6513e6a 100644
--- a/arch/mips/sgi-ip27/ip27-timer.c
+++ b/arch/mips/sgi-ip27/ip27-timer.c
@@ -27,8 +27,6 @@
#include <asm/sn/addrs.h>
#include <asm/sn/agent.h>
-#include "ip27-common.h"
-
#define TICK_SIZE (tick_nsec / 1000)
/* Includes for ioc3_init(). */
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c
2020-05-19 12:28 [PATCH] MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c Tiezhu Yang
@ 2020-05-19 16:03 ` Thomas Bogendoerfer
2020-05-20 4:57 ` Tiezhu Yang
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2020-05-19 16:03 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: linux-mips, linux-kernel, Xuefeng Li
On Tue, May 19, 2020 at 08:28:11PM +0800, Tiezhu Yang wrote:
> After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27
> declarations to ip27-common.h"), ip27-common.h is included more
> than once in ip27-timer.c, remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
applied to mips-next. I only removed the second #include. If you
want to clean this up further the includes and comment about
ioc3_init() could be removed as well.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c
2020-05-19 16:03 ` Thomas Bogendoerfer
@ 2020-05-20 4:57 ` Tiezhu Yang
0 siblings, 0 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-05-20 4:57 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel, Xuefeng Li
On 05/20/2020 12:03 AM, Thomas Bogendoerfer wrote:
> On Tue, May 19, 2020 at 08:28:11PM +0800, Tiezhu Yang wrote:
>> After commit 9d0aaf98dc24 ("MIPS: SGI-IP27: Move all shared IP27
>> declarations to ip27-common.h"), ip27-common.h is included more
>> than once in ip27-timer.c, remove it.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> applied to mips-next. I only removed the second #include. If you
> want to clean this up further the includes and comment about
> ioc3_init() could be removed as well.
OK, thank you. I will do it later.
Thanks,
Tiezhu Yang
>
> Thomas.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-20 4:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-19 12:28 [PATCH] MIPS: SGI-IP27: Remove duplicated include in ip27-timer.c Tiezhu Yang
2020-05-19 16:03 ` Thomas Bogendoerfer
2020-05-20 4:57 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox