Re: [PATCH v8 09/10] dt-bindings: interconnect: Add interconnect-tags bindings

Rob Herring
2020-05-19T18:58:41Z

On Tue, May 12, 2020 at 03:53:26PM +0300, Georgi Djakov wrote:
> From: Sibi Sankar <sibis@codeaurora.org>
>
> Add interconnect-tags bindings to enable passing of optional
> tag information to the interconnect framework.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> v8:
> * New patch, picked from here:
> https://lore.kernel.org/r/20200504202243.5476-10-sibis@codeaurora.org
>
> .../devicetree/bindings/interconnect/interconnect.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/interconnect.txt b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> index 6f5d23a605b7..c1a226a934e5 100644
> --- a/Documentation/devicetree/bindings/interconnect/interconnect.txt
> +++ b/Documentation/devicetree/bindings/interconnect/interconnect.txt
> @@ -55,6 +55,11 @@ interconnect-names : List of interconnect path name strings sorted in the same
> * dma-mem: Path from the device to the main memory of
> the system
>
> +interconnect-tags : List of interconnect path tags sorted in the same order as the
> + interconnects property. Consumers can append a specific tag to
> + the path and pass this information to the interconnect framework
> + to do aggregation based on the attached tag.

Why isn't this information in the 'interconnect' arg cells?

We have 'interconnect-names' because strings don't mix with cells. An
expanding list of 'interconnect-.*' is not a good pattern IMO.

Rob