From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7D9C433E0 for ; Tue, 19 May 2020 22:33:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22CB820674 for ; Tue, 19 May 2020 22:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S9LyVVx9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgESWd6 (ORCPT ); Tue, 19 May 2020 18:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgESWd5 (ORCPT ); Tue, 19 May 2020 18:33:57 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB684C061A0E for ; Tue, 19 May 2020 15:33:57 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id m7so477232plt.5 for ; Tue, 19 May 2020 15:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d2S5rKQKMJ+vUpUVcLBLOVq44Yhp+me9A/Z4UO/jFR0=; b=S9LyVVx9SQFnKBLDQjVRgdFLhlX48ZY8d19GgfrpPk5bCpo8aPrpT7R4eRzoYDCRy1 Fp8azzOWXKRy/9rnYcM1V6PmwOnfT1k66f4T8u7RUUc/azX5EKoxBAqy2QO4Vj7KotQq yCQVhYBKCEXG6UFvS2T64qy906bQEeWnOdjsjr01wC4rvnfCRlkU6tbj6lOUMd7HXphV h1RJs0Ka3QTQ8B5ynATChDUdQ2beRpSHDx4j25Rdz5hNC5C7Vof4ahgB+vjjjP/xfG1w 5lIhnr6ugGrN/awsjHF1UcQOPeMjKQHYBsXIhJ0XccQpQXrRM5HApcdX0u/rvnQ155/+ Bddg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d2S5rKQKMJ+vUpUVcLBLOVq44Yhp+me9A/Z4UO/jFR0=; b=km58KRHYFZG+s8u9pDn24uDIIxYHoPTmbqRipGq6LFqCFenS8g/ELQbrME+X53Fi0T DPJN7fGcKYvmGMXoqxtGSbYjMs7k7NZw9TleuJ3jNLSyPDX+kwwYiW62hjIUECzuJcT1 DPE5/Oo958tjEMnSjOMARVLZAMrqhp7t4ZBnKkXGa+Sklhy2X4V/E5ElAJFnxuEOkuaM 1MWoXMLG+RYH+U+YHDCoX9hy3vNKxkGJyhx20TDf97KxL6FIBbwRoySlUHzTr1k7ZG5a 0c2cLDMYGmLW+zCnbS8IfxcMjulhGY1vLopqutMIG4T8fAvbgS7fmf4av/a2dQ3/w5xe fJuQ== X-Gm-Message-State: AOAM530gq5tWmg7qLShqexZMo3otw5MS1SNobBFtphd1798z/sjDBEdI 2xJVMSOr/l0o1bNW2GAXpydK3A== X-Google-Smtp-Source: ABdhPJxuVLFOqG6CZpwV4kGE4gTI04IoXATiK/wOjORPZUwTl15EJyM0Ho5VHx+Qcedi64VEt1G0Qw== X-Received: by 2002:a17:90a:648a:: with SMTP id h10mr1904527pjj.69.1589927637197; Tue, 19 May 2020 15:33:57 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id c21sm397057pfo.131.2020.05.19.15.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 15:33:56 -0700 (PDT) Date: Tue, 19 May 2020 16:33:54 -0600 From: Mathieu Poirier To: Arun Kumar Neelakantam Cc: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org, sricharan@codeaurora.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Message-ID: <20200519223354.GC26832@xps15> References: <1589346671-15226-1-git-send-email-aneela@codeaurora.org> <1589346671-15226-4-git-send-email-aneela@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589346671-15226-4-git-send-email-aneela@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 10:41:10AM +0530, Arun Kumar Neelakantam wrote: > Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes s/TICOMGET/TIOCMGET > to get/set the low level transport signals. > > Signed-off-by: Arun Kumar Neelakantam > --- > drivers/rpmsg/rpmsg_char.c | 53 +++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 50 insertions(+), 3 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index 4bbbacd..e2f92f3 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > + * Copyright (c) 2018, The Linux Foundation. > * Copyright (c) 2016, Linaro Ltd. > * Copyright (c) 2012, Michal Simek > * Copyright (c) 2012, PetaLogix > @@ -19,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -269,15 +271,60 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait) > return mask; > } > > +static int rpmsg_eptdev_tiocmset(struct file *fp, unsigned int cmd, > + int __user *arg) > +{ > + struct rpmsg_eptdev *eptdev = fp->private_data; > + u32 set, clear, val; > + int ret; > + > + ret = get_user(val, arg); > + if (ret) > + return ret; > + set = clear = 0; > + switch (cmd) { > + case TIOCMBIS: > + set = val; > + break; > + case TIOCMBIC: > + clear = val; > + break; > + case TIOCMSET: > + set = val; > + clear = ~val; > + break; > + } > + > + set &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; > + clear &= TIOCM_DTR | TIOCM_RTS | TIOCM_CD | TIOCM_RI; > + > + return rpmsg_set_signals(eptdev->ept, set, clear); > +} > + > static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, > unsigned long arg) > { > struct rpmsg_eptdev *eptdev = fp->private_data; > + int ret; > > - if (cmd != RPMSG_DESTROY_EPT_IOCTL) > - return -EINVAL; > + switch (cmd) { > + case TIOCMGET: > + ret = rpmsg_get_signals(eptdev->ept); > + if (ret >= 0) > + ret = put_user(ret, (int __user *)arg); > + break; > + case TIOCMSET: > + case TIOCMBIS: > + case TIOCMBIC: > + ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg); > + break; > + case RPMSG_DESTROY_EPT_IOCTL: > + ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL); > + default: > + ret = -EINVAL; > + } > > - return rpmsg_eptdev_destroy(&eptdev->dev, NULL); > + return ret; > } > > static const struct file_operations rpmsg_eptdev_fops = { > -- > 2.7.4