From: Jason Gunthorpe <jgg@ziepe.ca>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
cohuck@redhat.com, peterx@redhat.com
Subject: Re: [PATCH 2/2] vfio: Introduce strict PFNMAP mappings
Date: Tue, 19 May 2020 21:20:55 -0300 [thread overview]
Message-ID: <20200520002055.GC31189@ziepe.ca> (raw)
In-Reply-To: <158947512947.12590.4756232870747830161.stgit@gimli.home>
On Thu, May 14, 2020 at 10:52:09AM -0600, Alex Williamson wrote:
> vfio_unregister_iommu_driver(&vfio_noiommu_ops);
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index 62ba6bd8a486..8d6286d89230 100644
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -61,6 +61,11 @@ module_param_named(dma_entry_limit, dma_entry_limit, uint, 0644);
> MODULE_PARM_DESC(dma_entry_limit,
> "Maximum number of user DMA mappings per container (65535).");
>
> +static bool strict_mmio_maps = true;
> +module_param_named(strict_mmio_maps, strict_mmio_maps, bool, 0644);
> +MODULE_PARM_DESC(strict_mmio_maps,
> + "Restrict DMA mappings of MMIO to those provided by vfio bus drivers supporting invalidation (true).");
> +
This should probably explain that 'false' allows some kind of security
issue and maybe taint the kernel?
Do you think there is a reason to have this anyhow?
Jason
next prev parent reply other threads:[~2020-05-20 0:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 16:51 [PATCH 0/2] vfio/type1/pci: IOMMU PFNMAP invalidation Alex Williamson
2020-05-14 16:51 ` [PATCH 1/2] vfio: Introduce bus driver to IOMMU invalidation interface Alex Williamson
2020-05-20 0:19 ` Jason Gunthorpe
2020-05-14 16:52 ` [PATCH 2/2] vfio: Introduce strict PFNMAP mappings Alex Williamson
2020-05-20 0:20 ` Jason Gunthorpe [this message]
2020-05-14 21:25 ` [PATCH 0/2] vfio/type1/pci: IOMMU PFNMAP invalidation Peter Xu
2020-05-14 22:17 ` Alex Williamson
2020-05-14 22:24 ` Jason Gunthorpe
2020-05-14 22:55 ` Alex Williamson
2020-05-15 15:22 ` Peter Xu
2020-05-15 15:54 ` Alex Williamson
2020-05-20 0:24 ` Jason Gunthorpe
2020-05-20 0:23 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520002055.GC31189@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox