From: Thierry Reding <thierry.reding@gmail.com>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error
Date: Wed, 20 May 2020 11:40:35 +0200 [thread overview]
Message-ID: <20200520094035.GC2136208@ulmo> (raw)
In-Reply-To: <20200520084012.30190-1-dinghao.liu@zju.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
s/even it/even when it/
> the error handling path to keep the counter balanced.
>
> Also This driver forgets to call pm_runtime_disable() when
s/Also This/Also this/
> pm_runtime_get_sync() returns an error code.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/pci/controller/pci-tegra.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Otherwise looks correct. It's came as somewhat of a surprise to me that
pm_runtime_get_sync() increments the usage counter even on failure, but
it does indeed.
With the above fixes to the commit message:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-20 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:40 [PATCH] PCI: tegra: fix runtime pm imbalance on error Dinghao Liu
2020-05-20 9:40 ` Thierry Reding [this message]
2020-05-20 16:42 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 8:52 Dinghao Liu
2020-05-20 9:59 ` Thierry Reding
2020-05-20 16:37 ` Bjorn Helgaas
2020-05-20 18:09 ` Vidya Sagar
2020-05-29 10:23 ` Lorenzo Pieralisi
2020-05-29 10:58 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520094035.GC2136208@ulmo \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox