Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay

'Christoph Hellwig'
2020-05-21T09:08:20Z

On Thu, May 21, 2020 at 09:06:19AM +0000, David Laight wrote:
> > > The comment still applies, though. (re the duplication)
> >
> > Where do you see duplication?
>
> The whole thing just doesn't scale.
>
> As soon as you get to the slightly more complex requests
> like SCTP_INITMSG (which should probably be called to
> set the required number of data streams) you've either
> got replicated code or nested wrappers.

None of that is relevant to setting the nodelay option. If you actually
read through the series you'd say that whenever there was non-trivial
logic it is shared with getopt. However sharing just for purpose of
sharing doesn't make sense, so where the kernel API ended up just
setting a flag after taking the sock lock I did not opt for it.