linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Changbin Du <changbin.du@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/19] perf ftrace: add option -t/--tid to filter by thread id
Date: Wed, 20 May 2020 18:12:28 -0300	[thread overview]
Message-ID: <20200520211228.GE32678@kernel.org> (raw)
In-Reply-To: <20200510150628.16610-17-changbin.du@gmail.com>

Em Sun, May 10, 2020 at 11:06:25PM +0800, Changbin Du escreveu:
> This allows us to trace single thread instead of the whole process.

I was going to adjust the patch to add, but you forgot to add the entry
to tools/perf/Documentation/perf-ftrace.txt,

Please do so,

- Arnaldo
 
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>  tools/perf/builtin-ftrace.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
> index 0b39b6a88026..8d04e5afe2d3 100644
> --- a/tools/perf/builtin-ftrace.c
> +++ b/tools/perf/builtin-ftrace.c
> @@ -707,6 +707,8 @@ int cmd_ftrace(int argc, const char **argv)
>  		    "List available functions to filter"),
>  	OPT_STRING('p', "pid", &ftrace.target.pid, "pid",
>  		   "trace on existing process id"),
> +	OPT_STRING('t', "tid", &ftrace.target.tid, "tid",
> +		   "trace on existing thread id (exclusive to --pid)"),
>  	OPT_INCR('v', "verbose", &verbose,
>  		 "be more verbose"),
>  	OPT_BOOLEAN('a', "all-cpus", &ftrace.target.system_wide,
> -- 
> 2.25.1
> 

-- 

- Arnaldo

  reply	other threads:[~2020-05-20 21:12 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 15:06 [PATCH 00/19] perf: ftrace enhancement Changbin Du
2020-05-10 15:06 ` [PATCH 01/19] perf ftrace: trace system wide if no target is given Changbin Du
2020-05-20 20:47   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 02/19] perf ftrace: detect workload failure Changbin Du
2020-05-20 20:51   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 03/19] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-05-20 20:56   ` Arnaldo Carvalho de Melo
2020-05-31  5:52   ` Namhyung Kim
2020-06-06 14:28     ` Changbin Du
2020-05-10 15:06 ` [PATCH 04/19] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-05-20 20:58   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 05/19] perf ftrace: add option '-l/--list-functions' to list available functions Changbin Du
2020-05-20 20:59   ` Arnaldo Carvalho de Melo
2020-06-06 14:42     ` Changbin Du
2020-05-10 15:06 ` [PATCH 06/19] perf ftrace: add support for trace option sleep-time Changbin Du
2020-05-20 21:01   ` Arnaldo Carvalho de Melo
2020-05-31  5:56     ` Namhyung Kim
2020-06-06 14:19       ` Changbin Du
2020-05-10 15:06 ` [PATCH 07/19] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-05-20 21:01   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 08/19] perf ftrace: add option -l/--long-info to show more info Changbin Du
2020-05-20 21:02   ` Arnaldo Carvalho de Melo
2020-05-31  6:00     ` Namhyung Kim
2020-06-06 14:14     ` Changbin Du
2020-05-10 15:06 ` [PATCH 09/19] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-05-20 21:03   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 10/19] perf ftrace: add support for trace option funcgraph-tail Changbin Du
2020-05-20 21:03   ` Arnaldo Carvalho de Melo
2020-05-20 21:05   ` Arnaldo Carvalho de Melo
2020-05-31  6:07     ` Namhyung Kim
2020-06-25 11:21     ` Changbin Du
2020-05-10 15:06 ` [PATCH 11/19] perf ftrace: add option '-u/--userstacktrace' to show userspace stacktrace Changbin Du
2020-05-20 21:07   ` Arnaldo Carvalho de Melo
2020-06-14 11:15     ` Changbin Du
2020-05-10 15:06 ` [PATCH 12/19] perf ftrace: add support for tracing children processes Changbin Du
2020-05-20 21:07   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 13/19] perf ftrace: add option '-b/--buffer-size' to set per-cpu buffer size Changbin Du
2020-05-20 21:08   ` Arnaldo Carvalho de Melo
2020-06-06 14:43     ` Changbin Du
2020-05-10 15:06 ` [PATCH 14/19] perf ftrace: add option -P/--no-pager to disable pager Changbin Du
2020-05-20 21:09   ` Arnaldo Carvalho de Melo
2020-06-06 14:40     ` Changbin Du
2020-05-10 15:06 ` [PATCH 15/19] perf ftrace: show trace column header Changbin Du
2020-05-20 21:11   ` Arnaldo Carvalho de Melo
2020-06-06 14:37     ` Changbin Du
2020-05-10 15:06 ` [PATCH 16/19] perf ftrace: add option -t/--tid to filter by thread id Changbin Du
2020-05-20 21:12   ` Arnaldo Carvalho de Melo [this message]
2020-06-06 14:32     ` Changbin Du
2020-05-10 15:06 ` [PATCH 17/19] perf ftrace: add option -d/--delay to delay tracing Changbin Du
2020-05-20 21:13   ` Arnaldo Carvalho de Melo
2020-06-06 14:30     ` Changbin Du
2020-05-10 15:06 ` [PATCH 18/19] perf ftrace: add option --latency-format to display more info about delay Changbin Du
2020-05-20 21:14   ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 19/19] perf ftrace: add change log Changbin Du
2020-05-10 15:23 ` [PATCH 00/19] perf: ftrace enhancement Steven Rostedt
2020-05-10 16:18   ` Arnaldo Melo
2020-05-20 20:31 ` Arnaldo Carvalho de Melo
2020-05-26  0:17   ` Changbin Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520211228.GE32678@kernel.org \
    --to=acme@kernel.org \
    --cc=changbin.du@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).