From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69E0C433E0 for ; Thu, 21 May 2020 10:24:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8E3120721 for ; Thu, 21 May 2020 10:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbgEUKYc (ORCPT ); Thu, 21 May 2020 06:24:32 -0400 Received: from foss.arm.com ([217.140.110.172]:43980 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbgEUKY1 (ORCPT ); Thu, 21 May 2020 06:24:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6518230E; Thu, 21 May 2020 03:24:26 -0700 (PDT) Received: from bogus (unknown [10.37.12.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EBEE3F68F; Thu, 21 May 2020 03:24:23 -0700 (PDT) Date: Thu, 21 May 2020 11:24:20 +0100 From: Sudeep Holla To: Will Deacon Cc: Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Catalin Marinas , "linux-kernel@vger.kernel.org" , Steven Price , harb@amperecomputing.com, Sudeep Holla , Linux ARM Subject: Re: [PATCH v4 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support Message-ID: <20200521102420.GC6425@bogus> References: <158999823818.135150.13263761266508812198.b4-ty@kernel.org> <20200521070629.GB1131@bogus> <20200521075755.GA4668@willie-the-truck> <20200521081055.GD1131@bogus> <20200521091736.GA5091@willie-the-truck> <20200521092627.GB6425@bogus> <20200521101437.GB5360@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200521101437.GB5360@willie-the-truck> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2020 at 11:14:38AM +0100, Will Deacon wrote: > On Thu, May 21, 2020 at 10:26:27AM +0100, Sudeep Holla wrote: > > On Thu, May 21, 2020 at 10:17:39AM +0100, Will Deacon wrote: > > > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote: > > > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla wrote: > > > > > /me confused. Do you need the fix for this warning or you are happy to ignore? > > > > > > > > I want a fix for that, as I hope we can eventually turn this warning on by > > > > default and stop playing whack-a-mole when they come up. Most of these > > > > warnings are harmless, but occasionally the prototypes don't match exactly > > > > and cause real bugs depending on the configuration, and ensuring both > > > > sides include a common header file is an easy way to make it work > > > > more reliably. > > > > > > > > Note that the warning should come up for either W=1 or C=1, and I also > > > > think that > > > > new code should generally be written sparse-clean and have no warnings with > > > > 'make C=1' as a rule. > > > > > > Fair enough. Is anybody working on a tree-wide sweep for this, like we've > > > done for other things such as zero-length arrays? If so, I can start > > > enforcing this in the arch code as well (I haven't been so far, even though > > > I do run sparse on every commit). > > > > > > Anyway, I've dropped the last patch from the branch, and we can put a fix > > > for the missing prototype on top. > > > > > > > Thanks Will, sorry for the trouble. Though I can send the fix for the > > missing prototype right away, I would like to get my clang setup working > > as an opportunity. clang-8 that I have is failing vanilla v5.7-rc6 > > when expanding arm_smccc_1_1_* > > No trouble at all, really. I also saw this from Nathan the other day, which > may help you get up and running with clang: > > https://lore.kernel.org/r/20200520024736.GA854786@ubuntu-s3-xlarge-x86 > Thanks for the link, I will try some other time(may be next time I run into clang issue 😄). Anyway upgrading to clang-11 fixed the build issue. I will soon post the patch for missing prototype. -- Regards, Sudeep