From: Kees Cook <keescook@chromium.org>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] pstore/ram: Undefine the correct macro after a recent renaming
Date: Thu, 21 May 2020 14:56:13 -0700 [thread overview]
Message-ID: <202005211456.F9125761@keescook> (raw)
In-Reply-To: <20200521205223.175957-1-tyhicks@linux.microsoft.com>
On Thu, May 21, 2020 at 03:52:23PM -0500, Tyler Hicks wrote:
> Undefine parse_u32, instead of parse_size, as the name of the macro
> recently changed but the #undef directive wasn't updated at that time.
>
> Fixes: 6b31e99b85b0 ("pstore/ram: Refactor DT size parsing")
> Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
> ---
>
> Hi Kees - Here's a minor fixup that I noticed was needed while reviewing
> your for-next/pstore branch. It is only build-tested but I think that's
> all that's needed here.
Whoops! Thanks; applied!
-Kees
>
> Tyler
>
> fs/pstore/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index df8965817c7b..ca6d8a867285 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -674,7 +674,7 @@ static int ramoops_parse_dt(struct platform_device *pdev,
> parse_u32("flags", pdata->flags, 0);
> parse_u32("max-reason", pdata->max_reason, pdata->max_reason);
>
> -#undef parse_size
> +#undef parse_u32
>
> /*
> * Some old Chromebooks relied on the kernel setting the
> --
> 2.25.1
>
--
Kees Cook
prev parent reply other threads:[~2020-05-21 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 20:52 [PATCH -next] pstore/ram: Undefine the correct macro after a recent renaming Tyler Hicks
2020-05-21 21:56 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005211456.F9125761@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=tony.luck@intel.com \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox