Re: [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value

Hans Verkuil
2020-05-11T08:39:08Z

On 03/04/2020 11:40, Xia Jiang wrote:
> Change device node number from 3 to -1 because that the driver will
> also support jpeg encoder.
>
> Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index e2a1d850813b..a536fa95b3d6 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -1154,7 +1154,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
> jpeg->dec_vdev->device_caps = V4L2_CAP_STREAMING |
> V4L2_CAP_VIDEO_M2M_MPLANE;
>
> - ret = video_register_device(jpeg->dec_vdev, VFL_TYPE_GRABBER, 3);
> + ret = video_register_device(jpeg->dec_vdev, VFL_TYPE_GRABBER, -1);

VFL_TYPE_GRABBER was renamed to VFL_TYPE_VIDEO.

It looks like this patch series is not on top of the media_tree repo master branch.

Please make sure your patch series is on top of that.

Regards,

Hans

> if (ret) {
> v4l2_err(&jpeg->v4l2_dev, "Failed to register video device\n");
> goto err_dec_vdev_register;
>