From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: MugilRaj <dmugil2000@gmail.com>
Cc: devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] taging: speakup: remove volatile
Date: Fri, 22 May 2020 11:37:38 +0200 [thread overview]
Message-ID: <20200522093738.GA1231689@kroah.com> (raw)
In-Reply-To: <1590138989-6091-1-git-send-email-dmugil2000@gmail.com>
On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote:
> fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> Documentation/process/volatile-considered-harmful.rst
> Signed-off-by: MugilRaj <dmugil2000@gmail.com>
As Samuel said, you can't "just remove this", otherwise it would have
been done a long time ago, don't you think?
But for your next patch, you need to have a blank line before the
signed-off-by: line in order for it to be in a format the patch could be
merged in.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-22 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 9:16 [PATCH] taging: speakup: remove volatile MugilRaj
2020-05-22 9:21 ` Samuel Thibault
2020-05-22 9:37 ` Greg Kroah-Hartman [this message]
2020-05-22 10:34 ` Dan Carpenter
2020-05-22 16:36 ` Joe Perches
2020-05-22 17:13 ` Samuel Thibault
2020-05-22 17:22 ` Joe Perches
2020-05-22 17:25 ` Samuel Thibault
2020-05-22 17:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522093738.GA1231689@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmugil2000@gmail.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox