From: Sam Ravnborg <sam@ravnborg.org>
To: Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches
Date: Sat, 23 May 2020 08:54:12 +0200 [thread overview]
Message-ID: <20200523065412.GA1591726@ravnborg.org> (raw)
In-Reply-To: <7db8ff3ee32bddfb6f82760468caa86388bee9bd.camel@redhat.com>
Hi Lyude.
> > > *dev, unsigned int pipe,
> > >
> > > DRM_DEBUG_VBL("updating vblank count on crtc %u:"
> > > " current=%llu, diff=%u, hw=%u hw_last=%u\n",
> > > - pipe, atomic64_read(&vblank->count), diff,
> > > + pipe, (unsigned long long)atomic64_read(&vblank->count),
> > > diff,
> > > cur_vblank, vblank->last);
> >
> > While touching this you could consider introducing drm_dbg_vbl().
> > An maybe as a follow-up patch replace all logging in this file with the drm_*
> > variants.
>
> ok - no promises when I can actually get to this though, I've got a lot on my
> plate ATM
I wnet ahead and applied this patch (after fixing a too long line),
and then I updated the logging functions as suggested above.
I applied the patch to drm-misc-next.
Patches with updated logging coming.
Sam
next prev parent reply other threads:[~2020-05-23 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 20:46 [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches Lyude Paul
2020-05-21 21:09 ` Sam Ravnborg
2020-05-22 18:18 ` Lyude Paul
2020-05-23 6:54 ` Sam Ravnborg [this message]
2020-05-22 6:30 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523065412.GA1591726@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox