* [PATCH] printk: Remove pr_cont_once()
@ 2020-05-24 15:32 Tetsuo Handa
2020-05-24 18:49 ` Joe Perches
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tetsuo Handa @ 2020-05-24 15:32 UTC (permalink / raw)
To: Andrew Morton, Petr Mladek, Sergey Senozhatsky, Steven Rostedt
Cc: linux-kernel, Tetsuo Handa, Joe Perches
pr_cont_once() does not make sense; at least emitting module name using
pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
sense. Let's remove unused pr_cont_once().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Joe Perches <joe@perches.com>
---
include/linux/printk.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/printk.h b/include/linux/printk.h
index 2562ffb438ed..4c565871f659 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -476,8 +476,7 @@ extern int kptr_restrict;
printk_once(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info_once(fmt, ...) \
printk_once(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
-#define pr_cont_once(fmt, ...) \
- printk_once(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__)
+/* no pr_cont_once, don't do that... */
#if defined(DEBUG) || defined(CONFIG_TWIST_ALWAYS_EVALUATE_DEBUG_PRINTK)
#define pr_devel_once(fmt, ...) \
--
2.18.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] printk: Remove pr_cont_once()
2020-05-24 15:32 [PATCH] printk: Remove pr_cont_once() Tetsuo Handa
@ 2020-05-24 18:49 ` Joe Perches
2020-05-25 8:03 ` Petr Mladek
2020-05-25 8:41 ` Sergey Senozhatsky
2 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2020-05-24 18:49 UTC (permalink / raw)
To: Tetsuo Handa, Andrew Morton, Petr Mladek, Sergey Senozhatsky,
Steven Rostedt
Cc: linux-kernel
On Mon, 2020-05-25 at 00:32 +0900, Tetsuo Handa wrote:
> pr_cont_once() does not make sense; at least emitting module name using
> pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
> sense. Let's remove unused pr_cont_once().
Right, thanks.
It's nearly a decade old cut'n'paste defect and
no one has ever used it or noticed it until now.
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Joe Perches <joe@perches.com>
> ---
> include/linux/printk.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 2562ffb438ed..4c565871f659 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -476,8 +476,7 @@ extern int kptr_restrict;
> printk_once(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
> #define pr_info_once(fmt, ...) \
> printk_once(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> -#define pr_cont_once(fmt, ...) \
> - printk_once(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__)
> +/* no pr_cont_once, don't do that... */
>
> #if defined(DEBUG) || defined(CONFIG_TWIST_ALWAYS_EVALUATE_DEBUG_PRINTK)
> #define pr_devel_once(fmt, ...) \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] printk: Remove pr_cont_once()
2020-05-24 15:32 [PATCH] printk: Remove pr_cont_once() Tetsuo Handa
2020-05-24 18:49 ` Joe Perches
@ 2020-05-25 8:03 ` Petr Mladek
2020-05-25 8:41 ` Sergey Senozhatsky
2 siblings, 0 replies; 5+ messages in thread
From: Petr Mladek @ 2020-05-25 8:03 UTC (permalink / raw)
To: Tetsuo Handa
Cc: Andrew Morton, Sergey Senozhatsky, Steven Rostedt, linux-kernel,
Joe Perches
On Mon 2020-05-25 00:32:43, Tetsuo Handa wrote:
> pr_cont_once() does not make sense; at least emitting module name using
> pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
> sense. Let's remove unused pr_cont_once().
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Joe Perches <joe@perches.com>
Makes semse.
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] printk: Remove pr_cont_once()
2020-05-24 15:32 [PATCH] printk: Remove pr_cont_once() Tetsuo Handa
2020-05-24 18:49 ` Joe Perches
2020-05-25 8:03 ` Petr Mladek
@ 2020-05-25 8:41 ` Sergey Senozhatsky
2020-05-25 9:07 ` Petr Mladek
2 siblings, 1 reply; 5+ messages in thread
From: Sergey Senozhatsky @ 2020-05-25 8:41 UTC (permalink / raw)
To: Tetsuo Handa
Cc: Andrew Morton, Petr Mladek, Sergey Senozhatsky, Steven Rostedt,
linux-kernel, Joe Perches
On (20/05/25 00:32), Tetsuo Handa wrote:
> pr_cont_once() does not make sense; at least emitting module name using
> pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
> sense. Let's remove unused pr_cont_once().
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Joe Perches <joe@perches.com>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] printk: Remove pr_cont_once()
2020-05-25 8:41 ` Sergey Senozhatsky
@ 2020-05-25 9:07 ` Petr Mladek
0 siblings, 0 replies; 5+ messages in thread
From: Petr Mladek @ 2020-05-25 9:07 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Tetsuo Handa, Andrew Morton, Steven Rostedt, linux-kernel,
Joe Perches
On Mon 2020-05-25 17:41:10, Sergey Senozhatsky wrote:
> On (20/05/25 00:32), Tetsuo Handa wrote:
> > pr_cont_once() does not make sense; at least emitting module name using
> > pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
> > sense. Let's remove unused pr_cont_once().
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Cc: Joe Perches <joe@perches.com>
>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
The patch is committed into printk/linux.git, branch for-5.8.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-25 9:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-24 15:32 [PATCH] printk: Remove pr_cont_once() Tetsuo Handa
2020-05-24 18:49 ` Joe Perches
2020-05-25 8:03 ` Petr Mladek
2020-05-25 8:41 ` Sergey Senozhatsky
2020-05-25 9:07 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox