From: Pavel Machek <pavel@ucw.cz>
To: Hongbo Yao <yaohongbo@huawei.com>
Cc: jansimon.moeller@gmx.de, jacek.anaszewski@gmail.com,
chenzhou10@huawei.com, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH -next] leds: blinkm: remove set but not used variable
Date: Mon, 25 May 2020 12:49:45 +0200 [thread overview]
Message-ID: <20200525104945.GA27989@amd> (raw)
In-Reply-To: <20200509142357.33702-1-yaohongbo@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Sat 2020-05-09 22:23:57, Hongbo Yao wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/leds/leds-blinkm.c:483:6: warning: variable ‘ret’ set
> but not used [-Wunused-but-set-variable]
> int ret;
Should error be propagated?
Pavel
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> ---
> drivers/leds/leds-blinkm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index e11fe1788242..a493ee0e0fc7 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -480,9 +480,8 @@ static int blinkm_led_blue_set(struct led_classdev *led_cdev,
>
> static void blinkm_init_hw(struct i2c_client *client)
> {
> - int ret;
> - ret = blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> - ret = blinkm_transfer_hw(client, BLM_GO_RGB);
> + blinkm_transfer_hw(client, BLM_STOP_SCRIPT);
> + blinkm_transfer_hw(client, BLM_GO_RGB);
> }
>
> static int blinkm_test_run(struct i2c_client *client)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2020-05-25 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 14:23 [PATCH -next] leds: blinkm: remove set but not used variable Hongbo Yao
2020-05-25 10:49 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525104945.GA27989@amd \
--to=pavel@ucw.cz \
--cc=chenzhou10@huawei.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jansimon.moeller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox