From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wei Yang <richard.weiyang@gmail.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: akpm@linux-foundation.org, christian.brauner@ubuntu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: simplify get_count_order_long()
Date: Mon, 25 May 2020 18:32:16 +0300 [thread overview]
Message-ID: <20200525153216.GD1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200525144312.mbw2z3ydncyasvss@master>
On Mon, May 25, 2020 at 02:43:12PM +0000, Wei Yang wrote:
> On Mon, May 25, 2020 at 12:14:58PM +0300, Andy Shevchenko wrote:
> >On Sun, May 24, 2020 at 12:35:51PM +0000, Wei Yang wrote:
> >> These two cases could be unified into one.
> >
> >Care to provide a test case which supports your change?
> >
>
> Hmm.. where should I put the test? tools/testing/selftests/ ?
I guess into test_bitops.c [1]? I though it eventually should make kernel, but I don't see it.
Andrew, can you apply that or do you need Jesse to resend?
[1]: https://lore.kernel.org/lkml/20200310221747.2848474-2-jesse.brandeburg@intel.com/
>
> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> >> ---
> >> include/linux/bitops.h | 5 +----
> >> 1 file changed, 1 insertion(+), 4 deletions(-)
> >>
> >> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> >> index 9acf654f0b19..5b5609e81a84 100644
> >> --- a/include/linux/bitops.h
> >> +++ b/include/linux/bitops.h
> >> @@ -206,10 +206,7 @@ static inline int get_count_order_long(unsigned long l)
> >> {
> >> if (l == 0UL)
> >> return -1;
> >> - else if (l & (l - 1UL))
> >> - return (int)fls_long(l);
> >> - else
> >> - return (int)fls_long(l) - 1;
> >> + return (int)fls_long(--l);
> >> }
> >
> >--
> >With Best Regards,
> >Andy Shevchenko
> >
>
> --
> Wei Yang
> Help you, Help me
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-25 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 12:35 [PATCH] bitops: simplify get_count_order_long() Wei Yang
2020-05-25 9:14 ` Andy Shevchenko
2020-05-25 14:43 ` Wei Yang
2020-05-25 15:32 ` Andy Shevchenko [this message]
2020-05-25 20:41 ` Andrew Morton
2020-05-25 21:57 ` Wei Yang
2020-05-25 22:31 ` Andrew Morton
2020-05-27 22:45 ` Wei Yang
2020-05-27 23:05 ` Andrew Morton
2020-05-28 22:18 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525153216.GD1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox