From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF618C433DF for ; Tue, 26 May 2020 12:33:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86D6B2084C for ; Tue, 26 May 2020 12:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590496384; bh=J/ofThaxaM0xtQe0vxdfxn88U1thkKvd6+Zp8nzo9Dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BPKNzXzPxDPeMVH4awoE5FpUY6mNUytLX0dxAeyx9vi6uSBV2kQXCKqpd9mumIzl+ ClUoAoQi92GdBw/npUEnp8l4BuVXliKbYfk5GTrUb+TTwOd8XZ/fk476ELHnSspDsd vTib/yPp+3ASHNixJVtyuutS6/IziPk3uNQIauxI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389087AbgEZMdD (ORCPT ); Tue, 26 May 2020 08:33:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:46374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbgEZMdD (ORCPT ); Tue, 26 May 2020 08:33:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65C92207CB; Tue, 26 May 2020 12:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590496382; bh=J/ofThaxaM0xtQe0vxdfxn88U1thkKvd6+Zp8nzo9Dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VI8lVcZaStraG3F7QrFdbQRFYgTSpxxmY5UByKI031j2asxt8f9es5GWacdgl8yvG IjTmGv3pBiv4nKsyLjwd518QH8y/M7YpXKpGJPyhx7iiW/5gp2O+3BNZsf93QMkRG5 CSK8+BDK2gsYwlFpNJWpzFatILursP5MvwYZVt6g= Date: Tue, 26 May 2020 14:33:00 +0200 From: Greg KH To: Alexander Graf Cc: Andra Paraschiv , linux-kernel@vger.kernel.org, Anthony Liguori , Benjamin Herrenschmidt , Colm MacCarthaigh , Bjoern Doebel , David Woodhouse , Frank van der Linden , Martin Pohlack , Matt Wilson , Paolo Bonzini , Balbir Singh , Stefano Garzarella , Stefan Hajnoczi , Stewart Smith , Uwe Dannowski , kvm@vger.kernel.org, ne-devel-upstream@amazon.com Subject: Re: [PATCH v3 07/18] nitro_enclaves: Init misc device providing the ioctl interface Message-ID: <20200526123300.GA2798@kroah.com> References: <20200525221334.62966-1-andraprs@amazon.com> <20200525221334.62966-8-andraprs@amazon.com> <20200526065133.GD2580530@kroah.com> <72647fa4-79d9-7754-9843-a254487703ea@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72647fa4-79d9-7754-9843-a254487703ea@amazon.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 01:42:41PM +0200, Alexander Graf wrote: > > > On 26.05.20 08:51, Greg KH wrote: > > > > On Tue, May 26, 2020 at 01:13:23AM +0300, Andra Paraschiv wrote: > > > +#define NE "nitro_enclaves: " > > > > Again, no need for this. > > > > > +#define NE_DEV_NAME "nitro_enclaves" > > > > KBUILD_MODNAME? > > > > > +#define NE_IMAGE_LOAD_OFFSET (8 * 1024UL * 1024UL) > > > + > > > +static char *ne_cpus; > > > +module_param(ne_cpus, charp, 0644); > > > +MODULE_PARM_DESC(ne_cpus, " - CPU pool used for Nitro Enclaves"); > > > > Again, please do not do this. > > I actually asked her to put this one in specifically. > > The concept of this parameter is very similar to isolcpus= and maxcpus= in > that it takes CPUs away from Linux and instead donates them to the > underlying hypervisor, so that it can spawn enclaves using them. > > From an admin's point of view, this is a setting I would like to keep > persisted across reboots. How would this work with sysfs? How about just as the "initial" ioctl command to set things up? Don't grab any cpu pools until asked to. Otherwise, what happens when you load this module on a system that can't support it? module parameters are a major pain, you know this :) > So yes, let's give everyone in CC the change to review v3 properly first > before v4 goes out. > > > And get them to sign off on it too, showing they agree with the design > > decisions here :) > > I would expect a Reviewed-by tag as a result from the above would satisfy > this? :) That would be most appreciated. thanks, greg k-h