From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E226C433E0 for ; Tue, 26 May 2020 15:01:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53F8C2084C for ; Tue, 26 May 2020 15:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729818AbgEZPBj (ORCPT ); Tue, 26 May 2020 11:01:39 -0400 Received: from foss.arm.com ([217.140.110.172]:51970 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728110AbgEZPBj (ORCPT ); Tue, 26 May 2020 11:01:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8C8A30E; Tue, 26 May 2020 08:01:38 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B893B3F52E; Tue, 26 May 2020 08:01:37 -0700 (PDT) Date: Tue, 26 May 2020 16:01:35 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Will Deacon , Suzuki K Poulose , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] arm64/cpufeature: Add get_arm64_ftr_reg_nowarn() Message-ID: <20200526150135.GI17051@gaia> References: <1590500353-28082-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590500353-28082-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 07:09:13PM +0530, Anshuman Khandual wrote: > @@ -632,8 +654,6 @@ static void __init init_cpu_ftr_reg(u32 sys_reg, u64 new) > const struct arm64_ftr_bits *ftrp; > struct arm64_ftr_reg *reg = get_arm64_ftr_reg(sys_reg); > > - BUG_ON(!reg); > - > for (ftrp = reg->ftr_bits; ftrp->width; ftrp++) { > u64 ftr_mask = arm64_ftr_mask(ftrp); > s64 ftr_new = arm64_ftr_value(ftrp, new); > @@ -762,7 +782,6 @@ static int check_update_ftr_reg(u32 sys_id, int cpu, u64 val, u64 boot) > { > struct arm64_ftr_reg *regp = get_arm64_ftr_reg(sys_id); > > - BUG_ON(!regp); > update_cpu_ftr_reg(regp, val); > if ((boot & regp->strict_mask) == (val & regp->strict_mask)) > return 0; > @@ -776,9 +795,6 @@ static void relax_cpu_ftr_reg(u32 sys_id, int field) > const struct arm64_ftr_bits *ftrp; > struct arm64_ftr_reg *regp = get_arm64_ftr_reg(sys_id); > > - if (WARN_ON(!regp)) > - return; I think Will wanted an early return in all these functions not just removing the BUG_ON(). I'll let him clarify. -- Catalin