From: Tejun Heo <tj@kernel.org>
To: qiang.zhang@windriver.com
Cc: jiangshanlai@gmail.com, markus.elfring@web.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Date: Wed, 27 May 2020 09:52:14 -0400 [thread overview]
Message-ID: <20200527135214.GI83516@mtj.thefacebook.com> (raw)
In-Reply-To: <20200527075715.36849-1-qiang.zhang@windriver.com>
On Wed, May 27, 2020 at 03:57:15PM +0800, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
>
> The data structure member "wq->rescuer" was reset to a null pointer
> in one if branch. It was passed to a call of the function "kfree"
> in the callback function "rcu_free_wq" (which was eventually executed).
> The function "kfree" does not perform more meaningful data processing
> for a passed null pointer (besides immediately returning from such a call).
> Thus delete this function call which became unnecessary with the referenced
> software update.
>
> Fixes: def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")
>
> Suggested-by: Markus Elfring <Markus.Elfring@web.de>
> Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
Applied to wq/for-5.8.
Thanks.
--
tejun
next prev parent reply other threads:[~2020-05-27 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:57 [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() qiang.zhang
2020-05-27 8:20 ` Markus Elfring
[not found] ` <DM6PR11MB32573F3884A864ECD586235EFF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
2020-05-28 1:44 ` 回复: " Zhang, Qiang
2020-05-28 9:57 ` Dan Carpenter
2020-05-28 10:38 ` Tejun Heo
2020-05-28 11:00 ` [v5] " Markus Elfring
2020-05-28 14:40 ` Markus Elfring
2020-05-28 12:08 ` 回复: [PATCH v5] " Lai Jiangshan
2020-05-28 12:25 ` Dan Carpenter
2020-05-28 13:27 ` Lai Jiangshan
2020-05-28 14:03 ` Tejun Heo
2020-05-28 14:45 ` [v5] " Markus Elfring
2020-05-28 14:06 ` 回复: [PATCH v5] " Dan Carpenter
2020-05-28 15:25 ` [v5] " Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-27 13:52 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-28 1:29 [PATCH v5] " qiang.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527135214.GI83516@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=qiang.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox