From: Dave Martin <Dave.Martin@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Stephen Boyd <swboyd@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org, Manoj Gupta <manojgupta@google.com>,
Luis Lozano <llozano@google.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm
Date: Wed, 27 May 2020 14:53:22 +0100 [thread overview]
Message-ID: <20200527135322.GU5031@arm.com> (raw)
In-Reply-To: <159052247565.23781.7800427985507723263.b4-ty@kernel.org>
On Tue, May 26, 2020 at 09:45:05PM +0100, Will Deacon wrote:
> On Tue, 26 May 2020 10:31:14 -0700, Nick Desaulniers wrote:
> > Custom toolchains that modify the default target to -mthumb cannot
It's probably too late to water this down, but it's unfortunate to have
this comment in the upstream commit history.
It's not constructive to call the native compiler configuration of
major distros for many years a "custom" toolchain. Unmodified GCC has
had a clean configure option for this for a very long time; it's not
someone's dirty hack. (The wisdom of armhf's choice of -mthumb might
be debated, but it is well established.)
Ignoring the triplet and passing random options to a compiler in the
hopes that it will do the right thing for an irregular usecase has never
been reliable. Usecases don't get much more irregular than building
vdso32.
arch/arm has the proper options in its Makefiles.
This patch is a kernel bugfix, plain and simple.
> > compile the arm64 compat vdso32, as
> > arch/arm64/include/asm/vdso/compat_gettimeofday.h
> > contains assembly that's invalid in -mthumb. Force the use of -marm,
> > always.
>
> Applied to arm64 (for-next/vdso), thanks!
>
> [1/1] arm64: vdso32: force vdso32 to be compiled as -marm
> https://git.kernel.org/arm64/c/20363b59ad4f
Does this need to go to stable?
Cheers
---Dave
next prev parent reply other threads:[~2020-05-27 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:31 [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm Nick Desaulniers
2020-05-26 18:55 ` Stephen Boyd
2020-05-26 20:45 ` Will Deacon
2020-05-27 13:53 ` Dave Martin [this message]
2020-05-27 17:58 ` Nick Desaulniers
2020-05-27 13:45 ` Robin Murphy
2020-05-27 17:55 ` Nick Desaulniers
2020-05-27 18:08 ` Will Deacon
2020-05-27 18:17 ` Nick Desaulniers
2020-05-28 7:20 ` Will Deacon
2020-06-08 20:57 ` [PATCH v2] arm64: vdso32: add CONFIG_THUMB2_COMPAT_VDSO Nick Desaulniers
2020-06-09 20:35 ` Catalin Marinas
2020-06-09 23:55 ` Nick Desaulniers
2020-06-10 8:47 ` Will Deacon
2020-06-10 10:29 ` Catalin Marinas
2020-06-10 10:32 ` Will Deacon
2020-06-10 11:21 ` Will Deacon
2020-05-27 19:28 ` [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm Robin Murphy
2020-05-27 20:02 ` Robin Murphy
2020-05-27 20:14 ` Nick Desaulniers
2020-05-27 20:31 ` Nick Desaulniers
2020-05-27 21:47 ` Nick Desaulniers
2020-05-28 8:05 ` Peter Smith
2020-05-28 9:41 ` Catalin Marinas
2020-05-28 19:06 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527135322.GU5031@arm.com \
--to=dave.martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=masahiroy@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=swboyd@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox