From: Tycho Andersen <tycho@tycho.ws>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>,
Matt Denton <mpdenton@google.com>,
Sargun Dhillon <sargun@sargun.me>, Jann Horn <jannh@google.com>,
Chris Palmer <palmer@google.com>,
Aleksa Sarai <cyphar@cyphar.com>,
Robert Sesek <rsesek@google.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH 1/2] seccomp: notify user trap about unused filter
Date: Wed, 27 May 2020 09:25:59 -0600 [thread overview]
Message-ID: <20200527152559.GB4153131@cisco> (raw)
In-Reply-To: <20200527111902.163213-1-christian.brauner@ubuntu.com>
On Wed, May 27, 2020 at 01:19:01PM +0200, Christian Brauner wrote:
> +void seccomp_filter_notify(const struct task_struct *tsk)
> +{
> + struct seccomp_filter *orig = tsk->seccomp.filter;
> +
> + while (orig && refcount_dec_and_test(&orig->live)) {
> + if (waitqueue_active(&orig->wqh))
> + wake_up_poll(&orig->wqh, EPOLLHUP);
> + orig = orig->prev;
> + }
> +}
Is there a reason this can't live in put_seccomp_filter()?
Tycho
next prev parent reply other threads:[~2020-05-27 15:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:19 [PATCH 1/2] seccomp: notify user trap about unused filter Christian Brauner
2020-05-27 11:19 ` [PATCH 2/2] tests: test seccomp filter notifications Christian Brauner
2020-05-27 15:25 ` Tycho Andersen [this message]
2020-05-27 15:35 ` [PATCH 1/2] seccomp: notify user trap about unused filter Christian Brauner
2020-05-27 17:37 ` Sargun Dhillon
2020-05-27 19:13 ` Christian Brauner
2020-05-27 21:43 ` Kees Cook
2020-05-27 21:52 ` Tycho Andersen
2020-05-27 22:36 ` Kees Cook
2020-05-27 22:56 ` Tycho Andersen
2020-05-28 1:50 ` Kees Cook
2020-05-27 22:05 ` Christian Brauner
2020-05-27 22:37 ` Kees Cook
2020-05-27 22:45 ` Christian Brauner
2020-05-27 23:16 ` Christian Brauner
2020-05-28 1:59 ` Kees Cook
2020-05-28 4:14 ` Jann Horn
2020-05-28 14:16 ` Christian Brauner
2020-05-28 14:39 ` Christian Brauner
2020-05-28 1:49 ` Kees Cook
2020-05-28 4:04 ` Jann Horn
2020-05-28 9:57 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527152559.GB4153131@cisco \
--to=tycho@tycho.ws \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=cyphar@cyphar.com \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mpdenton@google.com \
--cc=palmer@google.com \
--cc=rsesek@google.com \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox