Re: [PATCH 3/6] dt-bindings: serdev: ngsm: Add binding for GNSS child node

Pavel Machek
2021-03-05T10:47:34Z

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

Hi!

> > > For motorola modem case, we may have a GNSS device on channel 4.
> > > Let's add that to the binding and example.
> > >
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > ---
> > > .../devicetree/bindings/serdev/serdev-ngsm.yaml | 9 +++++++++
> > > 1 file changed, 9 insertions(+)

>
> And since we're describing a mux, I think you need nodes for the virtual
> ports rather than a reg property in what should be a serial client. That
> is something like
>
> serial@nnn {
> modem {
> compatible = "etsi,ts27001-mux";
>
> serial@4 {
> compatible = "etsi,ts27001-serial";
> reg = <4>;
>
> gnss {
> compatible = "motorola,motmdm-gnss";
> };
> };
> };
> };
>
> This way you can actually use serdev for the client drivers (e.g. for
> gnss), and those drivers also be used for non-muxed ports if needed
> (e.g. over USB).

I have done changes you requested, and then hit "serdev is busy
because it can have at most one child" limit in the code. You have
pretty clean driver in your inbox, and no reply. No help with serdev
core limitations, either. Can you start to communicate?

Best regards,
Pavel

--
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]