From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF696C433DF for ; Thu, 28 May 2020 12:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 962D7206F1 for ; Thu, 28 May 2020 12:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="OkNfGYgt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389847AbgE1Mjw (ORCPT ); Thu, 28 May 2020 08:39:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:47472 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389746AbgE1Mjt (ORCPT ); Thu, 28 May 2020 08:39:49 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04SCcBWp077816; Thu, 28 May 2020 12:39:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=9zN7Q4P5SLs/uK+J0DPJ8yIEgj4koWHklFCW9uYBztE=; b=OkNfGYgtVkPs5Vi30Ub2tw+HfAZ0nBlOoZTXHNlSVbs6yQvaoLG2Of2gMe3QDw5xa+wO Xl/+Y5+/OmShBO28mJ4sjL7+EAhIBw9B7m+kMO4YDDBcK4YDADEemELI7gLLDBtiACdm D+iriZQ2k6xvLSqUENZsyWPUlVCRR4JQZPaWTyPt4KZM3f2mYTRMI8fqevg2ZOIkp4fH 7kOQp0tIOJBAM+MYF17CifP3hpN8RYDomEapPCPRtduE5if0IEHZ6Zg49+D+LKpHMn83 eyEhG6gcW/c2zu7VKDx/DM36CjSXDPo2C2qSLX34ecqK78jugbcQVKRpaPei7CzGRXY9 Sg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 318xe1mqrt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 May 2020 12:39:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04SCJ6Ww003852; Thu, 28 May 2020 12:37:37 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 317ddsq3cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 May 2020 12:37:37 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 04SCbYFX004962; Thu, 28 May 2020 12:37:35 GMT Received: from mwanda (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 28 May 2020 05:37:33 -0700 Date: Thu, 28 May 2020 15:37:26 +0300 From: Dan Carpenter To: Oded Gabbay Cc: Arnd Bergmann , Greg Kroah-Hartman , Omer Shpigelman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] habanalabs: fix error code in unmap_device_va() Message-ID: <20200528123726.GB1219412@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9634 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0 suspectscore=2 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005280086 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9634 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 adultscore=0 cotscore=-2147483648 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=2 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005280087 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Smatch complains that "rc" can be uninitialized on certain paths. Fixes: 8ff5f4fd40df ("habanalabs: handle MMU cache invalidation timeout") Signed-off-by: Dan Carpenter --- drivers/misc/habanalabs/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/memory.c b/drivers/misc/habanalabs/memory.c index 4b8eed1ca5130..47da84a177197 100644 --- a/drivers/misc/habanalabs/memory.c +++ b/drivers/misc/habanalabs/memory.c @@ -1023,7 +1023,7 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr, bool ctx_free) struct hl_va_range *va_range; enum vm_type_t *vm_type; bool is_userptr; - int rc; + int rc = 0; /* protect from double entrance */ mutex_lock(&ctx->mem_hash_lock); -- 2.26.2