Re: [PATCH v2 1/2] regmap: provide helpers for simple bit operations

Mark Brown
2020-05-28T14:45:06Z

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

On Thu, May 28, 2020 at 04:22:40PM +0200, Bartosz Golaszewski wrote:

> + return (val & bits) == bits ? 1 : 0;

The tenery here is redundant, it's converting a boolean value into a
boolean value. Otherwise this looks good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]