From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC09C433DF for ; Fri, 29 May 2020 02:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFFE3207D3 for ; Fri, 29 May 2020 02:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pKc8no9E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436549AbgE2CuH (ORCPT ); Thu, 28 May 2020 22:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436466AbgE2Ct5 (ORCPT ); Thu, 28 May 2020 22:49:57 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52290C08C5C7 for ; Thu, 28 May 2020 19:49:57 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id x18so438528pll.6 for ; Thu, 28 May 2020 19:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hPip9sj+gT94IHX91SMv58k+bcYoNsqlEOg/dBUQ/BY=; b=pKc8no9EwMGl+SmmziguyIc8O2W2iMjna021zlfs9PD0U7z795t3f5ZCYmV5dwuGNy lh41h5fLmXXbMbeaQCOuEsEBnmZXXwnBOw0KbjkXCHqCoAvc7wpNcMO304+OFcfVEaCc 9/3+FxOmMw0bksABX67lYX6HGpflgVgbHxaYIw1VZjh7BoVXTXVhfZdb3z5p67q8hY88 OxSVlliRWGD9FtYXQOiK0KWX/L1MR3QcRVtIxsOWPLHH8nWmlCAefY2+JMwEFIueMk/+ 5WcbZe/9Nr1l0UdyKICRgLFH5iLHx6/OeFhs5ssf2f1xOLIl7UxB8r/bW2e0Sow+xQYN k0gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hPip9sj+gT94IHX91SMv58k+bcYoNsqlEOg/dBUQ/BY=; b=MjGfBZswufU/+QxcDPSX3WoGsLFAX7uV67KJeRllv21rki+ZL6Us34WYu7P/JC3xd8 gCzfAhePx97aezocM56zE6mmaGkMR8ycoJ446YF56xKrvo/BdF8WQBfDCOLXOw96Zhax WcnqQzoF/CKs9cmmU+Uvx/w1J+BBdJBndbRgS+4KB1rXxQjKM/z2XLnodWjimJdHcPZz 5S5PnLxmLmLRJ8gcqEEvCPvOekgeEaXwOA+DLQ15Ax4r1C7im/jmnL4qjcAjNdiDpQpi 4sI3wg+ijUkC1qHLkK6c70X68a0vBgVT3E2dQAj6uANc+qUThjV2KGbhbHp8BT1Nk76D QnFw== X-Gm-Message-State: AOAM531THxyIK/yUY9H6pQ0ma+W6aOj4YXcPws/rKy/fBSw+E7PVKhHJ UF5J1Grsm6iwrfVsQelLtFuDZg== X-Google-Smtp-Source: ABdhPJz09a79Fui6XxV+b6zrEokUmrQ2Q/jUgp2UxhnPU19f2ePwbMGzsXNI11Mg/LSXdryCF0u5hA== X-Received: by 2002:a17:902:848a:: with SMTP id c10mr6716560plo.124.1590720596694; Thu, 28 May 2020 19:49:56 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id z23sm5445646pga.86.2020.05.28.19.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 19:49:55 -0700 (PDT) Date: Thu, 28 May 2020 19:48:50 -0700 From: Bjorn Andersson To: Jonathan Marek Cc: Sai Prakash Ranjan , linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node Message-ID: <20200529024850.GU279327@builder.lan> References: <20200524023815.21789-1-jonathan@marek.ca> <20200524023815.21789-3-jonathan@marek.ca> <42f39eeb2af9c82a551a417c62ea21d7@codeaurora.org> <0f58e2fd-ef55-cf38-d403-4782662aa89e@marek.ca> <2a35f3b85d8311fb4298aaea82236967@codeaurora.org> <72d771390af9a68759d3f81cb79e46a6@codeaurora.org> <33b34a58-46d2-80ec-1d79-8e02aa5ae026@marek.ca> <1adedb96a999a08809afe62416e80075@codeaurora.org> <8f9a5750-7909-4be7-6780-198d8c242af3@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f9a5750-7909-4be7-6780-198d8c242af3@marek.ca> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 25 May 04:53 PDT 2020, Jonathan Marek wrote: [..] > I guess the commit message is ambiguous, that's not what I meant. Is "Now > that the kernel initializes the iommu, the bypass mappings set by the > bootloader are cleared. Adding the iommus property is required so that new > mappings are created for UFS." better? > This looks better, but it's actually not a bypass mapping that we inherit from the bootloader, it's the stream mapping pointing to a disabled (~ARM_SMMU_SCTLR_M) context bank. So when we wipe the stream mappings we will fault on the unmatched stream - which secure world "handles" for us... As such, I think you should replace "bypass" with "stream". Regards, Bjorn