Re: [PATCH 4/6] KVM: X86: Split kvm_update_cpuid()

Xiaoyao Li
2020-06-03T07:44:44Z

On 6/3/2020 9:10 AM, Sean Christopherson wrote:
> On Fri, May 29, 2020 at 04:55:43PM +0800, Xiaoyao Li wrote:
>> Split the part of updating KVM states from kvm_update_cpuid(), and put
>> it into a new kvm_update_state_based_on_cpuid(). So it's clear that
>> kvm_update_cpuid() is to update guest CPUID settings, while
>> kvm_update_state_based_on_cpuid() is to update KVM states based on the
>> updated CPUID settings.
>
> What about kvm_update_vcpu_model()? "state" isn't necessarily correct
> either.
>

yeah, it's better.