public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Dmitry Osipenko <digetx@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	peron.clem@gmail.com, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	linux-samsung-soc@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] regulator: do not balance regulators without constraints
Date: Fri, 29 May 2020 12:10:31 +0100	[thread overview]
Message-ID: <20200529111031.GI4610@sirena.org.uk> (raw)
In-Reply-To: <56e496bc-172f-d62f-5376-c8d734af6a51@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Fri, May 29, 2020 at 07:45:06AM +0200, Marek Szyprowski wrote:
> On 28.05.2020 15:43, Mark Brown wrote:

> > This forces every supply to have something which explicitly manages
> > voltages which means that if one of the coupled supplies doesn't really
> > care about the voltage (perhaps doesn't even have any explicit
> > consumers) and just needs to be within a certain range of another supply
> > then it'll end up restricting things needlessly.

> Frankly, that's exactly what we need for Exynos5422 case. If devfreq 
> driver is not enabled/compiled, we want to keep the "vdd_int" volatage 
> unchanged. This confirms me that we really need to have a custom coupler 
> for Exynos5422 case. It will solve such issues without adding hacks to 
> regulator core.

It sounds like you need that or some form of cooperation between the
devfreq and cpufreq drivers.

> > Saravana was trying to do some stuff with sync_state() which might be
> > interesting here although I have concerns with that approach too:

> >     https://lore.kernel.org/lkml/20200527074057.246606-1-saravanak@google.com/

> This still doesn't solve the above mentioned case.

I didn't mean the particular patch, I meant something using the
sync_state() callback.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-05-29 11:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200528131144eucas1p121b9151996fa3f780a5028f68c69d5ba@eucas1p1.samsung.com>
2020-05-28 13:11 ` [PATCH] regulator: do not balance regulators without constraints Marek Szyprowski
2020-05-28 13:43   ` Mark Brown
2020-05-29  5:45     ` Marek Szyprowski
2020-05-29 11:10       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529111031.GI4610@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=digetx@gmail.com \
    --cc=krzk@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=nm@ti.com \
    --cc=peron.clem@gmail.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox