From: Dan Carpenter <dan.carpenter@oracle.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, rspringer@google.com,
John Hubbard <jhubbard@nvidia.com>,
toddpoynor@google.com
Subject: Re: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()
Date: Fri, 29 May 2020 14:53:30 +0300 [thread overview]
Message-ID: <20200529115330.GO30374@kadam> (raw)
In-Reply-To: <20200528110408.GJ30374@kadam>
Anyway, can you resend with the commit message re-written. To me the
information that's most useful is from the lwn article:
"In short, if pages are being pinned for access to the data
contained within those pages, pin_user_pages() should be used. For
cases where the intent is to manipulate the page structures
corresponding to the pages rather than the data within them,
get_user_pages() is the correct interface."
What are the runtime implications of this patch? I'm still not clear on
that honestly.
When I'm reviewing patches, I also want to know how a bug was
introduced. In this case the original author did everything correctly
but we've just added some new features (cleanups. whatever).
I did skim the LWN article back in December but I don't remember the
details so I really want all this stuff re-stated in each commit
message.
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-29 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 21:02 [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*() Souptick Joarder
2020-05-28 11:04 ` Dan Carpenter
2020-05-29 6:16 ` Souptick Joarder
2020-05-29 6:27 ` Souptick Joarder
2020-05-29 7:38 ` John Hubbard
2020-05-29 7:45 ` Dan Carpenter
2020-05-29 7:46 ` Dan Carpenter
2020-05-29 8:00 ` John Hubbard
2020-05-29 11:53 ` Dan Carpenter [this message]
2020-05-29 20:28 ` John Hubbard
-- strict thread matches above, loose matches on Subject: below --
2020-05-31 7:23 Souptick Joarder
2020-05-31 8:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529115330.GO30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).