From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: please revert "Revert "media: staging: atomisp: Remove driver""
Date: Fri, 29 May 2020 16:46:15 +0200 [thread overview]
Message-ID: <20200529144615.GA2168030@kroah.com> (raw)
In-Reply-To: <20200529140907.GA2916@lst.de>
On Fri, May 29, 2020 at 04:09:07PM +0200, Christoph Hellwig wrote:
> Hi Mauro and Greg,
>
> the commit mentioned in the subject (commit id ad85094b293e in
> linux-next) contains the grave offense of adding a new set_fs address
> space override in "new" code. It also doesn't have an Ack from Greg
> despite showing up in drives/staging, which looks very suspicious.
>
> Please don't just add crap like this back if it doesn't pass the
> most basic sanity tests.
Mauro "owns" drivers/staging/media/ which is where this ended up in,
right? And I thought he had a bunch of follow-on patches that fixed up
crud like set_fs and friends.
Mauro, is your fixes not pushed in your tree as well?
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-29 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:09 please revert "Revert "media: staging: atomisp: Remove driver"" Christoph Hellwig
2020-05-29 14:46 ` Greg Kroah-Hartman [this message]
2020-05-29 15:14 ` Mauro Carvalho Chehab
2020-05-29 15:01 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529144615.GA2168030@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).