From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD60C433E0 for ; Sat, 30 May 2020 02:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0775C204EF for ; Sat, 30 May 2020 02:20:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FnWPc7sD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728692AbgE3CUb (ORCPT ); Fri, 29 May 2020 22:20:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57978 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgE3CUa (ORCPT ); Fri, 29 May 2020 22:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X9bkI2ilvEQW0erLexn/O2fz3158c1t2uQMV+b5J/gA=; b=FnWPc7sDhhjEGbZYaNBWQ0dcf9 /qowvyuJLOKGKdoyCmJ6HR8/tKxolRV/c9v4rrRMwD9Xi0LTcxq0qeHlxs/jKU0Xn0bHmfDxyG07H BY/SS8sflVtlPY4XFCM1FdaQ9WkCbcC06eJSddaVWg6eOt40E459Dx1XkinQ85KmUFBI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jer6k-003hnC-Ff; Sat, 30 May 2020 04:20:22 +0200 Date: Sat, 30 May 2020 04:20:22 +0200 From: Andrew Lunn To: Vadym Kochan Cc: David Miller , kuba@kernel.org, jiri@mellanox.com, idosch@mellanox.com, oleksandr.mazur@plvision.eu, serhiy.boiko@plvision.eu, serhiy.pshyk@plvision.eu, volodymyr.mytnyk@plvision.eu, taras.chornyi@plvision.eu, andrii.savka@plvision.eu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mickeyr@marvell.com Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Message-ID: <20200530022022.GI877847@lunn.ch> References: <20200528151245.7592-1-vadym.kochan@plvision.eu> <20200528151245.7592-2-vadym.kochan@plvision.eu> <20200529.171839.213046818110655879.davem@davemloft.net> <20200530004622.GA19411@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200530004622.GA19411@plvision.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2020 at 03:46:22AM +0300, Vadym Kochan wrote: > Hi David, > > On Fri, May 29, 2020 at 05:18:39PM -0700, David Miller wrote: > > > > Please remove all of the __packed attributes. > > > > I looked at your data structures and all of them use fixed sized types > > and are multiples of 4 so the __packed attribute is completely > > unnecessary. > > > > The alignment attribute is also unnecessary so please remove that too. > > Some of the fields are u8, so I assume there might be holes added by > the compiler ? Also these attributes guarantee some ABI compatibility > with FW side, I will try to remove them and check but it sounds for me a bit > risky. Hi Vadym You might want to play with pahole(1). Andrew