From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A604BC433DF for ; Sun, 31 May 2020 09:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8276A20707 for ; Sun, 31 May 2020 09:22:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ajT7JzS+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgEaJV7 (ORCPT ); Sun, 31 May 2020 05:21:59 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44626 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725813AbgEaJV6 (ORCPT ); Sun, 31 May 2020 05:21:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590916916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ywTf4qZlZwxY3+4hdzNIdEQ5uHrIZLnoqwJn0ChNVtk=; b=ajT7JzS+pKzwcmBQVFeYeTUME+i8AJIIN8K1sLRw8vESkpHOrX8ecVKo+l9/LSp17PxY0u hyHsZVr8RBvXRJd+DFjgaeME6QQe/WkAa8DkXV+H5L2TsfagQDXs7Op3x2jkwqJ3FmlXI3 nd85V8BUBeCtqdkb2/znyAfYfjY/Z38= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-2AxAwn-UNM6E9CFXUgQs0Q-1; Sun, 31 May 2020 05:21:52 -0400 X-MC-Unique: 2AxAwn-UNM6E9CFXUgQs0Q-1 Received: by mail-wr1-f69.google.com with SMTP id a4so3256331wrp.5 for ; Sun, 31 May 2020 02:21:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ywTf4qZlZwxY3+4hdzNIdEQ5uHrIZLnoqwJn0ChNVtk=; b=G/DhR9zNI3gez2vojXHhE2imrd1toywZK5tDlJENX+kcQK1fVm7+1b2IolVoGqiyAD 2Jvv55GF0mFLGhZuJEsbG6xcxBrzqzwQY6XyaD5nmP21nV07xxK8XY8bEXdMJhBrryRE NhqHmgPprUyADu6/Y9lgJ8sazKcR788h228Q3h2z+FLvDj2g3p6KV/abFeU8FViIs5R6 6MRG/XRBTKtLJv1bY3sjSzHAaU44y7Kr8KnBcnEdSyXA+aTi7gzg3pJZD6LNhNj4wXyV ji62JU2aFNpIuWKUpKCl7LKvSKA3m+pBoUOMpdSMwXEpKEYCLUmUD3W91i/QAEoQH2zB lCPQ== X-Gm-Message-State: AOAM531SHeWM92zWnvDYwW0r/XFnN7rZeIG7ukllVaAm2JH8gM/zVxJ5 v8+OMrKF39nponijZZnSyxsR8FfRXD2ScM/f6/ZXQozjQXIq4Rf4AfCY7/0s1zAuJydnvPxBSIW vbUg06BmXAdZU8afnArsfvShb X-Received: by 2002:a1c:230a:: with SMTP id j10mr16369534wmj.124.1590916911667; Sun, 31 May 2020 02:21:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzcgV6CUih1OZuVP6HyzHPhx3Qo76tys5xO9OetvdQfwhqn22ihHvFUhLx7Ow9OvlukxlV9g== X-Received: by 2002:a1c:230a:: with SMTP id j10mr16369518wmj.124.1590916911412; Sun, 31 May 2020 02:21:51 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id 23sm7468291wmo.18.2020.05.31.02.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 02:21:50 -0700 (PDT) Date: Sun, 31 May 2020 05:21:48 -0400 From: "Michael S. Tsirkin" To: Sasha Levin Cc: "Longpeng(Mike)" , linux-crypto@vger.kernel.org, Gonglei , Herbert Xu , Jason Wang , "David S. Miller" , Markus Elfring , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req() Message-ID: <20200531052126-mutt-send-email-mst@kernel.org> References: <20200526031956.1897-3-longpeng2@huawei.com> <20200526141138.8410D207FB@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526141138.8410D207FB@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 02:11:37PM +0000, Sasha Levin wrote: > <20200123101000.GB24255@Red> > References: <20200526031956.1897-3-longpeng2@huawei.com> > <20200123101000.GB24255@Red> > > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fixing commit: dbaf0624ffa5 ("crypto: add virtio-crypto driver"). > > The bot has tested the following trees: v5.6.14, v5.4.42, v4.19.124, v4.14.181. > > v5.6.14: Build OK! > v5.4.42: Failed to apply! Possible dependencies: > eee1d6fca0a0 ("crypto: virtio - switch to skcipher API") > > v4.19.124: Failed to apply! Possible dependencies: > eee1d6fca0a0 ("crypto: virtio - switch to skcipher API") > > v4.14.181: Failed to apply! Possible dependencies: > 500e6807ce93 ("crypto: virtio - implement missing support for output IVs") > 67189375bb3a ("crypto: virtio - convert to new crypto engine API") > d0d859bb87ac ("crypto: virtio - Register an algo only if it's supported") > e02b8b43f55a ("crypto: virtio - pr_err() strings should end with newlines") > eee1d6fca0a0 ("crypto: virtio - switch to skcipher API") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? Mike could you comment on backporting? > -- > Thanks > Sasha