Re: [PATCH 3/6] iio: dac: ad5592r-base: Constify struct iio_chan_spec_ext_info

Jonathan Cameron
2020-05-31T13:47:38Z

On Wed, 27 May 2020 04:22:46 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote:
> > [External]
> >
> > ad5592r_ext_info is not modified and can be made const to allow the
> > compiler to put it in read-only memory.
> >
> > Before:
> > text data bss dec hex filename
> > 13293 2088 256 15637 3d15 drivers/iio/dac/ad5592r-base.o
> >
> > After:
> > text data bss dec hex filename
> > 13421 1960 256 15637 3d15 drivers/iio/dac/ad5592r-base.o
> >
>
> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.

Thanks
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> > ---
> > drivers/iio/dac/ad5592r-base.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-
> > base.c
> > index 410e90e5f75f..7402f67a551d 100644
> > --- a/drivers/iio/dac/ad5592r-base.c
> > +++ b/drivers/iio/dac/ad5592r-base.c
> > @@ -484,7 +484,7 @@ static ssize_t ad5592r_show_scale_available(struct
> > iio_dev *iio_dev,
> > st->scale_avail[1][0], st->scale_avail[1][1]);
> > }
> >
> > -static struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
> > +static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
> > {
> > .name = "scale_available",
> > .read = ad5592r_show_scale_available,