From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801D6C433E0 for ; Sun, 31 May 2020 14:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EE682074A for ; Sun, 31 May 2020 14:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590936025; bh=6yQVUf6eZyFT6lMD1GCa340xEGAioytVxc9js4MHTtA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=lfDEdI8FkOf3fL/9OXfM5UK0qcjeUOvU2ruHeO/JOd4Rad/QfKySaZRkd9hoJI7WV 0k13Sz2/e0wCmmAmJe06soVJ43Hc1EZMFWRomll34wmXyVBlvsQZGFJaB/BN3OdKia qGp93dwrB723jIbWmHN87VL3zxz9jQxWennokriA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbgEaOkX (ORCPT ); Sun, 31 May 2020 10:40:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:40184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgEaOkW (ORCPT ); Sun, 31 May 2020 10:40:22 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88E2D206B6; Sun, 31 May 2020 14:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590936021; bh=6yQVUf6eZyFT6lMD1GCa340xEGAioytVxc9js4MHTtA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q63VwJGZvgs9AhjZpY0fXN9BcBIiEyov3MRaTZDQsiX6saVwTUWz9tE5t4z6k3hYQ 3cedlqnJ/TFbmsemKkxou43DrugEmzfxiOMj+GNpI0Y1Tr54qjOucpsFqRaisdyxVz 23RCq+ADdezYf+qglashef+UdCmMv5gMQZuANppc= Date: Sun, 31 May 2020 15:40:17 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , , Subject: Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver Message-ID: <20200531154017.04fc727f@archlinux> In-Reply-To: <20200525102744.131672-1-alexandru.ardelean@analog.com> References: <20200525102744.131672-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 May 2020 13:27:44 +0300 Alexandru Ardelean wrote: > Since changes can come from all sort of places, it may make sense to have > this symbol as a dependency to make sure that the 'make allmodconfig' && > 'make allyesconfig' build rules cover this driver as well for a > compile-build/test. > > It seemed useful [recently] when trying to apply a change for this. > > Signed-off-by: Alexandru Ardelean Makes sense. Given this sort of change can expose weird an wonderful dependencies that were previously hidden, I'll be wanting an ack from at91 people. Jonathan > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index c48c00077775..c1f4c0aec265 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -294,7 +294,7 @@ config ASPEED_ADC > > config AT91_ADC > tristate "Atmel AT91 ADC" > - depends on ARCH_AT91 > + depends on ARCH_AT91 || COMPILE_TEST > depends on INPUT && SYSFS > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER