From: Jon Mason <jdmason@kudzu.us>
To: Wesley Sheng <wesley.sheng@amd.com>
Cc: dave.jiang@intel.com, allenbh@gmail.com,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
wesleyshenggit@sina.com
Subject: Re: [PATCH] NTB: correct ntb_peer_spad_addr and ntb_peer_spad_read comment typos
Date: Sun, 31 May 2020 15:55:39 -0400 [thread overview]
Message-ID: <20200531195539.GD4620@kudzu.us> (raw)
In-Reply-To: <20200526075943.20756-1-wesley.sheng@amd.com>
On Tue, May 26, 2020 at 03:59:43PM +0800, Wesley Sheng wrote:
> The comment for ntb_peer_spad_addr and ntb_peer_spad_read
> incorrectly referred to peer doorbell register and local
> scratchpad register.
>
> Signed-off-by: Wesley Sheng <wesley.sheng@amd.com>
Pulled into the ntb branch
Thanks,
Jon
> ---
> include/linux/ntb.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/ntb.h b/include/linux/ntb.h
> index 8c13538aeffe..b9b0d805d0f9 100644
> --- a/include/linux/ntb.h
> +++ b/include/linux/ntb.h
> @@ -1351,7 +1351,7 @@ static inline int ntb_spad_write(struct ntb_dev *ntb, int sidx, u32 val)
> * @sidx: Scratchpad index.
> * @spad_addr: OUT - The address of the peer scratchpad register.
> *
> - * Return the address of the peer doorbell register. This may be used, for
> + * Return the address of the peer scratchpad register. This may be used, for
> * example, by drivers that offload memory copy operations to a dma engine.
> *
> * Return: Zero on success, otherwise an error number.
> @@ -1373,7 +1373,7 @@ static inline int ntb_peer_spad_addr(struct ntb_dev *ntb, int pidx, int sidx,
> *
> * Read the peer scratchpad register, and return the value.
> *
> - * Return: The value of the local scratchpad register.
> + * Return: The value of the peer scratchpad register.
> */
> static inline u32 ntb_peer_spad_read(struct ntb_dev *ntb, int pidx, int sidx)
> {
> --
> 2.16.2
>
prev parent reply other threads:[~2020-05-31 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 7:59 [PATCH] NTB: correct ntb_peer_spad_addr and ntb_peer_spad_read comment typos Wesley Sheng
2020-05-31 19:55 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531195539.GD4620@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=wesley.sheng@amd.com \
--cc=wesleyshenggit@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox