From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: s.nawrocki@samsung.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 2/3] mfd: madera: Fix minor formatting issues
Date: Mon, 1 Jun 2020 06:24:33 +0100 [thread overview]
Message-ID: <20200601052433.GA3714@dell> (raw)
In-Reply-To: <20200529155742.18399-2-ckeepax@opensource.cirrus.com>
On Fri, 29 May 2020, Charles Keepax wrote:
Still needs a commit log.
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/mfd/madera-core.c | 12 ++++++------
> drivers/mfd/madera-i2c.c | 1 -
> include/linux/mfd/madera/pdata.h | 1 -
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
> index 7e0835cb062b1..4724c1a01a39f 100644
> --- a/drivers/mfd/madera-core.c
> +++ b/drivers/mfd/madera-core.c
> @@ -44,7 +44,7 @@ static const char * const madera_core_supplies[] = {
> };
>
> static const struct mfd_cell madera_ldo1_devs[] = {
> - { .name = "madera-ldo1" },
> + { .name = "madera-ldo1", },
What issue does this solve?
Why are ','s a requirement, even for single entries?
> };
>
> static const char * const cs47l15_supplies[] = {
> @@ -55,8 +55,8 @@ static const char * const cs47l15_supplies[] = {
>
> static const struct mfd_cell cs47l15_devs[] = {
> { .name = "madera-pinctrl", },
> - { .name = "madera-irq" },
> - { .name = "madera-gpio" },
> + { .name = "madera-irq", },
> + { .name = "madera-gpio", },
> {
> .name = "madera-extcon",
> .parent_supplies = cs47l15_supplies,
> @@ -108,7 +108,7 @@ static const char * const cs47l85_supplies[] = {
> static const struct mfd_cell cs47l85_devs[] = {
> { .name = "madera-pinctrl", },
> { .name = "madera-irq", },
> - { .name = "madera-micsupp" },
> + { .name = "madera-micsupp", },
> { .name = "madera-gpio", },
> {
> .name = "madera-extcon",
> @@ -155,10 +155,10 @@ static const char * const cs47l92_supplies[] = {
> };
>
> static const struct mfd_cell cs47l92_devs[] = {
> - { .name = "madera-pinctrl" },
> + { .name = "madera-pinctrl", },
> { .name = "madera-irq", },
> { .name = "madera-micsupp", },
> - { .name = "madera-gpio" },
> + { .name = "madera-gpio", },
> {
> .name = "madera-extcon",
> .parent_supplies = cs47l92_supplies,
> diff --git a/drivers/mfd/madera-i2c.c b/drivers/mfd/madera-i2c.c
> index 6b965eb034b6c..7df5b9ba58554 100644
> --- a/drivers/mfd/madera-i2c.c
> +++ b/drivers/mfd/madera-i2c.c
> @@ -88,7 +88,6 @@ static int madera_i2c_probe(struct i2c_client *i2c,
> if (!madera)
> return -ENOMEM;
>
> -
> madera->regmap = devm_regmap_init_i2c(i2c, regmap_16bit_config);
> if (IS_ERR(madera->regmap)) {
> ret = PTR_ERR(madera->regmap);
> diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h
> index fa9595dd42ba5..601cbbc10370c 100644
> --- a/include/linux/mfd/madera/pdata.h
> +++ b/include/linux/mfd/madera/pdata.h
> @@ -21,7 +21,6 @@
>
> struct gpio_desc;
> struct pinctrl_map;
> -struct madera_codec_pdata;
This is not a formatting issue.
> /**
> * struct madera_pdata - Configuration data for Madera devices
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-01 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 15:57 [PATCH 1/3] mfd: arizona: Remove BUG_ON usage Charles Keepax
2020-05-29 15:57 ` [PATCH 2/3] mfd: madera: Fix minor formatting issues Charles Keepax
2020-06-01 5:24 ` Lee Jones [this message]
2020-06-01 9:54 ` Charles Keepax
2020-06-01 10:47 ` Lee Jones
2020-05-29 15:57 ` [PATCH 3/3] mfd: arizona: Ensure 32k clock is put on driver unbind and error Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601052433.GA3714@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox