From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: s.nawrocki@samsung.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 2/3] mfd: madera: Fix minor formatting issues
Date: Mon, 1 Jun 2020 11:47:58 +0100 [thread overview]
Message-ID: <20200601104758.GB3714@dell> (raw)
In-Reply-To: <20200601095443.GJ71940@ediswmail.ad.cirrus.com>
On Mon, 01 Jun 2020, Charles Keepax wrote:
> On Mon, Jun 01, 2020 at 06:24:33AM +0100, Lee Jones wrote:
> > On Fri, 29 May 2020, Charles Keepax wrote:
> >
> > Still needs a commit log.
> >
> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > ---
> > > drivers/mfd/madera-core.c | 12 ++++++------
> > > drivers/mfd/madera-i2c.c | 1 -
> > > include/linux/mfd/madera/pdata.h | 1 -
> > > 3 files changed, 6 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
> > > index 7e0835cb062b1..4724c1a01a39f 100644
> > > --- a/drivers/mfd/madera-core.c
> > > +++ b/drivers/mfd/madera-core.c
> > > @@ -44,7 +44,7 @@ static const char * const madera_core_supplies[] = {
> > > };
> > >
> > > static const struct mfd_cell madera_ldo1_devs[] = {
> > > - { .name = "madera-ldo1" },
> > > + { .name = "madera-ldo1", },
> >
> > What issue does this solve?
> >
> > Why are ','s a requirement, even for single entries?
> >
>
> Was more just a consistency thing, we seem to have ended up with
> half the lines having commas and half not, happy to move them all
> to not having comma's if that is your preference?
I don't have a preference. Consistency is more important to me.
Please describe your changes in the commit log.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-01 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 15:57 [PATCH 1/3] mfd: arizona: Remove BUG_ON usage Charles Keepax
2020-05-29 15:57 ` [PATCH 2/3] mfd: madera: Fix minor formatting issues Charles Keepax
2020-06-01 5:24 ` Lee Jones
2020-06-01 9:54 ` Charles Keepax
2020-06-01 10:47 ` Lee Jones [this message]
2020-05-29 15:57 ` [PATCH 3/3] mfd: arizona: Ensure 32k clock is put on driver unbind and error Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601104758.GB3714@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox