From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E090C433E0 for ; Mon, 1 Jun 2020 13:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25CB72074B for ; Mon, 1 Jun 2020 13:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591017337; bh=pgBlsyAymge/nNvcjWX4o/qICWkz88Sk6jQ6eVlnqUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lmW9OpEYaqeA5qFMRvJvVlCx2jemkmE2wmaJaz36/zsfQbhiICgRO5w0dX2CeR+aa UYIJWhCmtLkay4ZssJhq1StvfzYuKeC8jYfWPcTP3fWr1gmN/EEDVDLLFu2vssi/9f 5P9N3MP/zw6iM6gLLV6UH1R5WQDpDHkBmz3Ao2C0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgFANPg (ORCPT ); Mon, 1 Jun 2020 09:15:36 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41350 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbgFANPf (ORCPT ); Mon, 1 Jun 2020 09:15:35 -0400 Received: by mail-pg1-f194.google.com with SMTP id r10so3478035pgv.8; Mon, 01 Jun 2020 06:15:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+gDMWa+OGAKx46k7Cvh7kPbyjXS9KSSt0bfGnT+J5sY=; b=bfY6hGpdYKVzyY7QA6OCAukgzvBSy0pmtesmOYTb8F0dmtIwvdB4uz2+FyUfX/I+jb mct6x/4L33Bk4s010uuDOMGPwMDxNq17YvdL4cQ/gR7KP0ONbeyFirTrroHlyy6b6ZI9 1dVMoLG+6iad6WvnmZDK8icnhQfK43Rx1zBzBW8fYZd1+5r4nzarLum6SIT2G7n5rlpS RL1/ATqMANT/nn0cPdkOaX+zpOkNCWzLJUlKFm1Krfrm2+v80veELRnBKNXQxFU28k4J 7wTCOt+8Xgzu3ezNxXHWiwAsWnvp+BJLJLN6eZVBPdf9TD8gKoVye8mobs2u85/5gxwt 14pQ== X-Gm-Message-State: AOAM531AG3dQjc3YjXjEExYlANQBGDPXdsESY2j1LaSyVj0VX7F8zD7+ nenz7/6TQcUde3/6wTx4Qo0= X-Google-Smtp-Source: ABdhPJwWk/s5F4iwXHiVM9TgwWJgxm2fDnJu8jVLBQzoRLnqQx/zowwSN/CtZM419Rgp80gQFZEpqg== X-Received: by 2002:a05:6a00:80a:: with SMTP id m10mr20480731pfk.174.1591017334969; Mon, 01 Jun 2020 06:15:34 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id w192sm14601238pff.126.2020.06.01.06.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 06:15:33 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 4726440251; Mon, 1 Jun 2020 13:15:33 +0000 (UTC) Date: Mon, 1 Jun 2020 13:15:33 +0000 From: Luis Chamberlain To: Masami Hiramatsu Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Chris Wilson , Joonas Lahtinen , Kees Cook , Masami Hiramatsu Subject: Re: [PATCH 3/4] selftests/sysctl: Fix to load test_sysctl module Message-ID: <20200601131533.GI11244@42.do-not-panic.com> References: <159067751438.229397.6746886115540895104.stgit@devnote2> <159067754657.229397.15961438722058766667.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159067754657.229397.15961438722058766667.stgit@devnote2> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 11:52:26PM +0900, Masami Hiramatsu wrote: > Fix to load test_sysctl.ko module correctly. > > sysctl.sh checks whether the test module is embedded (or loaded > already) or not at first, and if not, it returns skip error > instead of trying modprobe. Thus, there is no chance to load the > test_sysctl test module. > > Instead, this removes that module embedded check and returns > skip error only if it ensures that there is no embedded test > module *and* no loadable test module. > > This also avoid referring config file since that is not > installed. > > Signed-off-by: Masami Hiramatsu Reviewed-by: Luis Chamberlain Luis