From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 4/7] selftests/ftrace: Convert required interface checks into requires list
Date: Tue, 2 Jun 2020 09:01:57 +0900 [thread overview]
Message-ID: <20200602090157.45cf58947267cec561da67ea@kernel.org> (raw)
In-Reply-To: <e23a0d5c-5e7e-13db-e9c1-2a093d3327be@linux.intel.com>
On Mon, 1 Jun 2020 14:54:12 -0500
"Zanussi, Tom" <tom.zanussi@linux.intel.com> wrote:
> Hi Masami,
>
> On 6/1/2020 9:42 AM, Masami Hiramatsu wrote:
> > Convert the required tracefs interface checking code with
> > requires: list.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org
> [ SNIP ]
>
> > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > index c80007aa9f86..59f876c80d45 100644
> > --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
> > @@ -1,17 +1,13 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0
> > # description: event trigger - test inter-event histogram trigger onchange action
> > +# requires: synthetic_events
>
> I think this should be 'set_event'
>
Thank you for point it out. I found another missed requirement.
I'll fix it.
Thank you,
> Thanks,
>
> Tom
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-06-02 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:42 [PATCH 0/7] selftsts/ftrace: Add requires list for each test case Masami Hiramatsu
2020-06-01 14:42 ` [PATCH 1/7] selftests/ftrace: Allow ":" in description Masami Hiramatsu
2020-06-01 14:42 ` [PATCH 2/7] selftests/ftrace: Return unsupported for the unconfigured features Masami Hiramatsu
2020-06-01 14:42 ` [PATCH 3/7] selftests/ftrace: Add "requires:" list support Masami Hiramatsu
2020-06-01 14:42 ` [PATCH 4/7] selftests/ftrace: Convert required interface checks into requires list Masami Hiramatsu
2020-06-01 19:54 ` Zanussi, Tom
2020-06-02 0:01 ` Masami Hiramatsu [this message]
2020-06-01 14:42 ` [PATCH 5/7] selftests/ftrace: Convert check_filter_file() with " Masami Hiramatsu
2020-06-01 14:43 ` [PATCH 6/7] selftests/ftrace: Support ":tracer" suffix for requires Masami Hiramatsu
2020-06-01 14:43 ` [PATCH 7/7] selftests/ftrace: Support ":README" " Masami Hiramatsu
2020-06-01 19:56 ` [PATCH 0/7] selftsts/ftrace: Add requires list for each test case Zanussi, Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602090157.45cf58947267cec561da67ea@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox