From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 2/2] perf tools: Remove some duplicated includes
Date: Tue, 2 Jun 2020 11:10:02 -0300 [thread overview]
Message-ID: <20200602141002.GQ31795@kernel.org> (raw)
In-Reply-To: <1591071304-19338-2-git-send-email-yangtiezhu@loongson.cn>
Em Tue, Jun 02, 2020 at 12:15:04PM +0800, Tiezhu Yang escreveu:
> There exists some duplicated includes in tools/perf, remove them.
Applied, thanks.
- Arnaldo
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> tools/perf/builtin-report.c | 1 -
> tools/perf/util/annotate.c | 1 -
> tools/perf/util/auxtrace.c | 1 -
> tools/perf/util/config.c | 1 -
> tools/perf/util/session.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index ba63390..5425a2c 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -47,7 +47,6 @@
> #include "util/time-utils.h"
> #include "util/auxtrace.h"
> #include "util/units.h"
> -#include "util/branch.h"
> #include "util/util.h" // perf_tip()
> #include "ui/ui.h"
> #include "ui/progress.h"
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index d828c2d..76bfb4a 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -41,7 +41,6 @@
> #include <linux/bitops.h>
> #include <linux/kernel.h>
> #include <linux/string.h>
> -#include <bpf/libbpf.h>
> #include <subcmd/parse-options.h>
> #include <subcmd/run-command.h>
>
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index 749487a..94a8f4f 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -55,7 +55,6 @@
> #include "util/mmap.h"
>
> #include <linux/ctype.h>
> -#include <linux/kernel.h>
> #include "symbol/kallsyms.h"
> #include <internal/lib.h>
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index ef38eba..64f14a5 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -20,7 +20,6 @@
> #include "build-id.h"
> #include "debug.h"
> #include "config.h"
> -#include "debug.h"
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <stdlib.h>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index c11d89e..5550e26e 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -33,7 +33,6 @@
> #include "../perf.h"
> #include "arch/common.h"
> #include <internal/lib.h>
> -#include <linux/err.h>
>
> #ifdef HAVE_ZSTD_SUPPORT
> static int perf_session__process_compressed_event(struct perf_session *session,
> --
> 2.1.0
>
--
- Arnaldo
next prev parent reply other threads:[~2020-06-02 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 4:15 [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Tiezhu Yang
2020-06-02 4:15 ` [PATCH 2/2] perf tools: Remove some duplicated includes Tiezhu Yang
2020-06-02 14:10 ` Arnaldo Carvalho de Melo [this message]
2020-06-02 14:11 ` [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Arnaldo Carvalho de Melo
2020-06-02 14:15 ` Jiri Olsa
2020-06-03 2:01 ` Tiezhu Yang
2020-06-04 8:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602141002.GQ31795@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox