From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: Kaaira Gupta <kgupta@es.iitr.ac.in>,
linux-media@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: vimc: Add color descriptions to test image
Date: Wed, 3 Jun 2020 02:26:44 +0300 [thread overview]
Message-ID: <20200602232644.GO6547@pendragon.ideasonboard.com> (raw)
In-Reply-To: <dd4e19e7-285b-dced-bc0d-5aca38019b44@collabora.com>
Hi Helen,
On Mon, Jun 01, 2020 at 01:36:59PM -0300, Helen Koike wrote:
> On 6/1/20 10:53 AM, Kaaira Gupta wrote:
> > Hi!
> >
> > Currently there is no method to know if the test image generated by vimc
> > is correct (except for comparing it with a known 'correct' image). So, I
> > wanted to investigate about a possibility to add text to each color bar
> > of the generated pattern. I think currently vivid supports this
> > functionality as an optional control, so can we move it to a common
> > platform so that both VIVID and VIMC can supoort it?
>
> If it is useful I don't oppose, but I'm not sure how this is implemented
> in vivid (or if it is in tpg).
> I guess it is easier to judge from an RFC code :)
To add a bit of context, we've had incorrect code in qcam (libcamera)
for months, with the RGB and BGR formats swapped. I never noticed
because the test pattern doesn't immediately appear wrong when you swap
red and blue. Adding text in the colour bars to tell what colour they
should be would help visual verification of the pattern.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2020-06-02 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:53 vimc: Add color descriptions to test image Kaaira Gupta
2020-06-01 16:36 ` Helen Koike
2020-06-01 18:06 ` Kaaira Gupta
2020-06-02 23:26 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602232644.GO6547@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kgupta@es.iitr.ac.in \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox