From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DED0C433DF for ; Tue, 2 Jun 2020 23:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AAC22072F for ; Tue, 2 Jun 2020 23:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Qfet7hoP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbgFBX1C (ORCPT ); Tue, 2 Jun 2020 19:27:02 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38126 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgFBX1C (ORCPT ); Tue, 2 Jun 2020 19:27:02 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 206442A4; Wed, 3 Jun 2020 01:27:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1591140420; bh=VumH+P4JzJKXTE/EJbY3up9YLg/7/l8XzAp6tqchldA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qfet7hoPSV8ga3ygXLmLAXKcfVYTKOvCccn3qSAkG3UmhSizwMkZycsJpYb1SzYdP fbOUr/Fvrp+A+DB1r0CkWgxNgQqNmJHxdIAEvzRC0ZBu9rRfPVWPCaa/K1p4WMsYiI 6alkxnjCJCVC5qE1beG5ISCtjbZOYY9g12wLWdgQ= Date: Wed, 3 Jun 2020 02:26:44 +0300 From: Laurent Pinchart To: Helen Koike Cc: Kaaira Gupta , linux-media@vger.kernel.org, Shuah Khan , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com, Hans Verkuil Subject: Re: vimc: Add color descriptions to test image Message-ID: <20200602232644.GO6547@pendragon.ideasonboard.com> References: <20200601135339.GA16606@kaaira-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Helen, On Mon, Jun 01, 2020 at 01:36:59PM -0300, Helen Koike wrote: > On 6/1/20 10:53 AM, Kaaira Gupta wrote: > > Hi! > > > > Currently there is no method to know if the test image generated by vimc > > is correct (except for comparing it with a known 'correct' image). So, I > > wanted to investigate about a possibility to add text to each color bar > > of the generated pattern. I think currently vivid supports this > > functionality as an optional control, so can we move it to a common > > platform so that both VIVID and VIMC can supoort it? > > If it is useful I don't oppose, but I'm not sure how this is implemented > in vivid (or if it is in tpg). > I guess it is easier to judge from an RFC code :) To add a bit of context, we've had incorrect code in qcam (libcamera) for months, with the RGB and BGR formats swapped. I never noticed because the test pattern doesn't immediately appear wrong when you swap red and blue. Adding text in the colour bars to tell what colour they should be would help visual verification of the pattern. -- Regards, Laurent Pinchart